Refactor new Thread(new Runnable() { public void run ... to new Thread() { public void run ... by just override Thead#run directly

zhourenjian · zhourenjian · commit 717518714b06 · 2009-05-06T22:46:20.000Z
diff --git a/sources/net.sf.j2s.ajax/ajaxcore/net/sf/j2s/ajax/AClass.java b/sources/net.sf.j2s.ajax/ajaxcore/net/sf/j2s/ajax/AClass.java
@@ -62,7 +62,7 @@ protected AClass() {
 	 * }, false, true);
 	 */
 	public static void load(final String clazzName, final Runnable afterLoaded) {
-		new Thread(new Runnable() {
+		(new Thread() {
 			public void run() {
 				try {
 					Class clz = Class.forName(clazzName);
diff --git a/sources/net.sf.j2s.ajax/ajaxcore/net/sf/j2s/ajax/HttpRequest.java b/sources/net.sf.j2s.ajax/ajaxcore/net/sf/j2s/ajax/HttpRequest.java
@@ -353,7 +353,7 @@ public void send() {
 	public void send(String str) {
 		content = str;
 		if (asynchronous) {
-			new Thread(new Runnable() {
+			(new Thread() {
 				public void run() {
 					if (!toAbort) {
 						request();
diff --git a/sources/net.sf.j2s.ajax/ajaxpipe/net/sf/j2s/ajax/SimplePipeRequest.java b/sources/net.sf.j2s.ajax/ajaxpipe/net/sf/j2s/ajax/SimplePipeRequest.java
@@ -179,7 +179,7 @@ protected static void sendRequest(HttpRequest request, String method, String url
 	public static void pipe(final SimplePipeRunnable runnable) {
 		runnable.ajaxIn();
 		if (getRequstMode() == MODE_LOCAL_JAVA_THREAD) {
-			new Thread(new Runnable() {
+			(new Thread("Pipe Request Thread") {
 				public void run() {
 					try {
 						runnable.ajaxRun();
@@ -191,7 +191,7 @@ public void run() {
 					keepPipeLive(runnable);
 					runnable.ajaxOut();
 				}
-			}, "Pipe Request Thread").start();
+			}).start();
 		} else {
 			pipeRequest(runnable);
 		}
@@ -204,7 +204,7 @@ public void run() {
 	 */
 	@J2SIgnore
 	static void keepPipeLive(final SimplePipeRunnable runnable) {
-		new Thread(new Runnable() {
+		Thread thread = new Thread(new Runnable() {
 			
 			public void run() {
 				long lastLiveDetected = System.currentTimeMillis();
@@ -267,7 +267,9 @@ public void run() {
 				} while (true);
 			}
 		
-		}, "Pipe Live Notifier Thread").start();
+		}, "Pipe Live Notifier Thread");
+		thread.setDaemon(true);
+		thread.start();
 	}
 
 	private static void pipeRequest(final SimplePipeRunnable runnable) {
@@ -871,7 +873,7 @@ static void ajaxPipe(final SimplePipeRunnable runnable) {
 			 */
 		{
 			//pipeQuery(runnable, "continuum");
-			new Thread(new Runnable(){
+			(new Thread(){
 				public void run() {
 					pipeContinuum(runnable);
 				}
@@ -923,7 +925,7 @@ public void run() {
 		{
 			final String key = runnable.pipeKey;
 			final long created = new Date().getTime();
-			new Thread(new Runnable() {
+			Thread thread = new Thread("Pipe Monitor Thread") {
 				public void run() {
 					SimplePipeRunnable runnable = null;
 					while ((runnable = SimplePipeHelper.getPipe(key)) != null) {
@@ -949,7 +951,9 @@ public void run() {
 						}
 					}
 				}
-			}, "Pipe Monitor Thread").start();
+			};
+			thread.setDaemon(true);
+			thread.start();
 		}
 	}
 
diff --git a/sources/net.sf.j2s.ajax/ajaxpipe/net/sf/j2s/ajax/SimplePipeRunnable.java b/sources/net.sf.j2s.ajax/ajaxpipe/net/sf/j2s/ajax/SimplePipeRunnable.java
@@ -166,7 +166,7 @@ public void pipeClosed() {
 	 * @return pipe is live or not.
 	 */
 	public boolean isPipeLive() {
-		return pipeAlive;
+		return pipeAlive && !destroyed;
 	}
 	
 	/**
@@ -192,7 +192,7 @@ protected void pipeMonitoring() {
 			ManagedPipeHelper.monitoringPipe(this);
 			return;
 		}
-		new Thread(new Runnable() {
+		Thread thread = new Thread("Pipe Monitor") {
 			
 			public void run() {
 				lastLiveDetected = System.currentTimeMillis();
@@ -222,7 +222,9 @@ public void run() {
 				}
 			}
 		
-		}, "Pipe Monitor").start();
+		};
+		thread.setDaemon(true);
+		thread.start();
 	}
 
 	/**
diff --git a/sources/net.sf.j2s.ajax/ajaxrpc/net/sf/j2s/ajax/SimpleRPCRequest.java b/sources/net.sf.j2s.ajax/ajaxrpc/net/sf/j2s/ajax/SimpleRPCRequest.java
@@ -63,7 +63,7 @@ public static void switchToLocalJavaThreadMode() {
 	public static void request(final SimpleRPCRunnable runnable) {
 		runnable.ajaxIn();
 		if (runningMode == MODE_LOCAL_JAVA_THREAD) {
-			new Thread(new Runnable() {
+			(new Thread() {
 				public void run() {
 					try {
 						runnable.ajaxRun();
diff --git a/sources/net.sf.j2s.ajax/ajaxswt/net/sf/j2s/ajax/AWindowDelegate.java b/sources/net.sf.j2s.ajax/ajaxswt/net/sf/j2s/ajax/AWindowDelegate.java
@@ -89,7 +89,7 @@ public void widgetDisposed(DisposeEvent e) {
 			 * @j2sNative
 			 */
 		{
-			new Thread(new Runnable() {
+			(new Thread() {
 				public void run() {
 					while (win.getShell() == null) {
 						try {
diff --git a/sources/net.sf.j2s.ajax/ajaxswt/net/sf/j2s/ajax/SimplePipeSWTRequest.java b/sources/net.sf.j2s.ajax/ajaxswt/net/sf/j2s/ajax/SimplePipeSWTRequest.java
@@ -50,7 +50,7 @@ public void run() {
 				}
 			
 			});
-			new Thread(new Runnable(){
+			(new Thread(){
 				public void run() {
 					try {
 						runnable.ajaxRun();
@@ -88,7 +88,7 @@ public void run() {
 	 */
     @J2SIgnore
 	static void swtKeepPipeLive(final SimplePipeRunnable runnable, final Display disp) {
-		new Thread(new Runnable() {
+		Thread thread = new Thread("Pipe Live Notifier Thread") {
 			
 			public void run() {
 				long lastLiveDetected = System.currentTimeMillis();
@@ -157,7 +157,9 @@ public void run() {
 				} while (true);
 			}
 		
-		}, "Pipe Live Notifier Thread").start();
+		};
+		thread.setDaemon(true);
+		thread.start();
 	}
 
     @J2SIgnore
@@ -187,14 +189,14 @@ public void swtOnLoaded() {
 				SimplePipeHelper.registerPipe(runnable.pipeKey, runnable);
 
 				if (getPipeMode() == MODE_PIPE_CONTINUUM) {
-					new Thread(new Runnable(){
+					(new Thread(){
 						public void run() {
 							swtPipeContinuum(runnable);
 						}
 					}).start();
 				} else {
 					final String key = runnable.pipeKey;
-					new Thread(new Runnable() {
+					(new Thread("Pipe Monitor Thread") {
 						public void run() {
 							SimplePipeRunnable runnable = null;
 							while ((runnable = SimplePipeHelper.getPipe(key)) != null) {
@@ -206,7 +208,7 @@ public void run() {
 								}
 							}
 						}
-					}, "Pipe Monitor Thread").start();
+					}).start();
 				}
 
 			}
diff --git a/sources/net.sf.j2s.ajax/ajaxswt/net/sf/j2s/ajax/SimpleRPCSWTRequest.java b/sources/net.sf.j2s.ajax/ajaxswt/net/sf/j2s/ajax/SimpleRPCSWTRequest.java
@@ -32,7 +32,7 @@ public void run() {
 			}
 		});
 		if (getRequstMode() == MODE_LOCAL_JAVA_THREAD) {
-			new Thread(new Runnable(){
+			(new Thread(){
 				public void run() {
 					try {
 						runnable.ajaxRun();

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ protected static void sendRequest(HttpRequest request, String method, String url`
`179`	`179`	`public static void pipe(final SimplePipeRunnable runnable) {`
`180`	`180`	`runnable.ajaxIn();`
`181`	`181`	`if (getRequstMode() == MODE_LOCAL_JAVA_THREAD) {`
`182`		`- new Thread(new Runnable() {`
	`182`	`+ (new Thread("Pipe Request Thread") {`
`183`	`183`	`public void run() {`
`184`	`184`	`try {`
`185`	`185`	`runnable.ajaxRun();`
`@@ -191,7 +191,7 @@ public void run() {`
`191`	`191`	`keepPipeLive(runnable);`
`192`	`192`	`runnable.ajaxOut();`
`193`	`193`	`}`
`194`		`- }, "Pipe Request Thread").start();`
	`194`	`+ }).start();`
`195`	`195`	`} else {`
`196`	`196`	`pipeRequest(runnable);`
`197`	`197`	`}`
`@@ -204,7 +204,7 @@ public void run() {`
`204`	`204`	`*/`
`205`	`205`	`@J2SIgnore`
`206`	`206`	`static void keepPipeLive(final SimplePipeRunnable runnable) {`
`207`		`- new Thread(new Runnable() {`
	`207`	`+ Thread thread = new Thread(new Runnable() {`
`208`	`208`
`209`	`209`	`public void run() {`
`210`	`210`	`long lastLiveDetected = System.currentTimeMillis();`
`@@ -267,7 +267,9 @@ public void run() {`
`267`	`267`	`} while (true);`
`268`	`268`	`}`
`269`	`269`
`270`		`- }, "Pipe Live Notifier Thread").start();`
	`270`	`+ }, "Pipe Live Notifier Thread");`
	`271`	`+ thread.setDaemon(true);`
	`272`	`+ thread.start();`
`271`	`273`	`}`
`272`	`274`
`273`	`275`	`private static void pipeRequest(final SimplePipeRunnable runnable) {`
`@@ -871,7 +873,7 @@ static void ajaxPipe(final SimplePipeRunnable runnable) {`
`871`	`873`	`*/`
`872`	`874`	`{`
`873`	`875`	`//pipeQuery(runnable, "continuum");`
`874`		`- new Thread(new Runnable(){`
	`876`	`+ (new Thread(){`
`875`	`877`	`public void run() {`
`876`	`878`	`pipeContinuum(runnable);`
`877`	`879`	`}`
`@@ -923,7 +925,7 @@ public void run() {`
`923`	`925`	`{`
`924`	`926`	`final String key = runnable.pipeKey;`
`925`	`927`	`final long created = new Date().getTime();`
`926`		`- new Thread(new Runnable() {`
	`928`	`+ Thread thread = new Thread("Pipe Monitor Thread") {`
`927`	`929`	`public void run() {`
`928`	`930`	`SimplePipeRunnable runnable = null;`
`929`	`931`	`while ((runnable = SimplePipeHelper.getPipe(key)) != null) {`
`@@ -949,7 +951,9 @@ public void run() {`
`949`	`951`	`}`
`950`	`952`	`}`
`951`	`953`	`}`
`952`		`- }, "Pipe Monitor Thread").start();`
	`954`	`+ };`
	`955`	`+ thread.setDaemon(true);`
	`956`	`+ thread.start();`
`953`	`957`	`}`
`954`	`958`	`}`
`955`	`959`
Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ public void pipeClosed() {`
`166`	`166`	`* @return pipe is live or not.`
`167`	`167`	`*/`
`168`	`168`	`public boolean isPipeLive() {`
`169`		`- return pipeAlive;`
	`169`	`+ return pipeAlive && !destroyed;`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`/**`
`@@ -192,7 +192,7 @@ protected void pipeMonitoring() {`
`192`	`192`	`ManagedPipeHelper.monitoringPipe(this);`
`193`	`193`	`return;`
`194`	`194`	`}`
`195`		`- new Thread(new Runnable() {`
	`195`	`+ Thread thread = new Thread("Pipe Monitor") {`
`196`	`196`
`197`	`197`	`public void run() {`
`198`	`198`	`lastLiveDetected = System.currentTimeMillis();`
`@@ -222,7 +222,9 @@ public void run() {`
`222`	`222`	`}`
`223`	`223`	`}`
`224`	`224`
`225`		`- }, "Pipe Monitor").start();`
	`225`	`+ };`
	`226`	`+ thread.setDaemon(true);`
	`227`	`+ thread.start();`
`226`	`228`	`}`
`227`	`229`
`228`	`230`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public void widgetDisposed(DisposeEvent e) {`
`89`	`89`	`* @j2sNative`
`90`	`90`	`*/`
`91`	`91`	`{`
`92`		`- new Thread(new Runnable() {`
	`92`	`+ (new Thread() {`
`93`	`93`	`public void run() {`
`94`	`94`	`while (win.getShell() == null) {`
`95`	`95`	`try {`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public void run() {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`});`
`53`		`- new Thread(new Runnable(){`
	`53`	`+ (new Thread(){`
`54`	`54`	`public void run() {`
`55`	`55`	`try {`
`56`	`56`	`runnable.ajaxRun();`
`@@ -88,7 +88,7 @@ public void run() {`
`88`	`88`	`*/`
`89`	`89`	`@J2SIgnore`
`90`	`90`	`static void swtKeepPipeLive(final SimplePipeRunnable runnable, final Display disp) {`
`91`		`- new Thread(new Runnable() {`
	`91`	`+ Thread thread = new Thread("Pipe Live Notifier Thread") {`
`92`	`92`
`93`	`93`	`public void run() {`
`94`	`94`	`long lastLiveDetected = System.currentTimeMillis();`
`@@ -157,7 +157,9 @@ public void run() {`
`157`	`157`	`} while (true);`
`158`	`158`	`}`
`159`	`159`
`160`		`- }, "Pipe Live Notifier Thread").start();`
	`160`	`+ };`
	`161`	`+ thread.setDaemon(true);`
	`162`	`+ thread.start();`
`161`	`163`	`}`
`162`	`164`
`163`	`165`	`@J2SIgnore`
`@@ -187,14 +189,14 @@ public void swtOnLoaded() {`
`187`	`189`	`SimplePipeHelper.registerPipe(runnable.pipeKey, runnable);`
`188`	`190`
`189`	`191`	`if (getPipeMode() == MODE_PIPE_CONTINUUM) {`
`190`		`- new Thread(new Runnable(){`
	`192`	`+ (new Thread(){`
`191`	`193`	`public void run() {`
`192`	`194`	`swtPipeContinuum(runnable);`
`193`	`195`	`}`
`194`	`196`	`}).start();`
`195`	`197`	`} else {`
`196`	`198`	`final String key = runnable.pipeKey;`
`197`		`- new Thread(new Runnable() {`
	`199`	`+ (new Thread("Pipe Monitor Thread") {`
`198`	`200`	`public void run() {`
`199`	`201`	`SimplePipeRunnable runnable = null;`
`200`	`202`	`while ((runnable = SimplePipeHelper.getPipe(key)) != null) {`
`@@ -206,7 +208,7 @@ public void run() {`
`206`	`208`	`}`
`207`	`209`	`}`
`208`	`210`	`}`
`209`		`- }, "Pipe Monitor Thread").start();`
	`211`	`+ }).start();`
`210`	`212`	`}`
`211`	`213`
`212`	`214`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public void run() {`
`32`	`32`	`}`
`33`	`33`	`});`
`34`	`34`	`if (getRequstMode() == MODE_LOCAL_JAVA_THREAD) {`
`35`		`- new Thread(new Runnable(){`
	`35`	`+ (new Thread(){`
`36`	`36`	`public void run() {`
`37`	`37`	`try {`
`38`	`38`	`runnable.ajaxRun();`