BigInteger getLowestSetBit coding error for 24-bit int

hansonr · hansonr · commit 615e860170e1 · 2019-02-28T15:50:38.000-06:00
diff --git a/sources/net.sf.j2s.java.core/src/java/math/BigInteger.java b/sources/net.sf.j2s.java.core/src/java/math/BigInteger.java
@@ -3473,7 +3473,7 @@ public int getLowestSetBit() {
                 int i,b;
                 for (i=0; (b = getInt(i)) == 0; i++)
                     ;
-                lsb += (i * BITS_PER_INT) + Integer.numberOfTrailingZeros(b) - SPARE_BITS_INT;
+                lsb += (i * BITS_PER_INT) + Integer.numberOfTrailingZeros(b);
             }
             lowestSetBit = lsb + 2;
         }
diff --git a/sources/net.sf.j2s.java.core/src/test/Test_BigInt.java b/sources/net.sf.j2s.java.core/src/test/Test_BigInt.java
@@ -8,6 +8,10 @@ public class Test_BigInt extends Test_ {
 
 	public static void main(String[] args) {
 
+		BigInteger m = BigInteger.valueOf(4);
+		m = m.modPow(BigInteger.valueOf(3), BigInteger.valueOf(8));
+		System.out.println(m);
+		//4^3 mod 8, 6^5 mod 2
 		BigDecimal e = new BigDecimal("200.05");
 		System.out.println(e);
 		BigDecimal f = new BigDecimal(45000);

Original file line number	Diff line number	Diff line change
`@@ -3473,7 +3473,7 @@ public int getLowestSetBit() {`
`3473`	`3473`	`int i,b;`
`3474`	`3474`	`for (i=0; (b = getInt(i)) == 0; i++)`
`3475`	`3475`	`;`
`3476`		`- lsb += (i * BITS_PER_INT) + Integer.numberOfTrailingZeros(b) - SPARE_BITS_INT;`
	`3476`	`+ lsb += (i * BITS_PER_INT) + Integer.numberOfTrailingZeros(b);`
`3477`	`3477`	`}`
`3478`	`3478`	`lowestSetBit = lsb + 2;`
`3479`	`3479`	`}`