dev notes "+" vs "%20" in URI.

BobHanson · BobHanson · commit 5af3957a2930 · 2020-06-26T12:25:17.000-05:00
Conclusion is that these are not HTML calls; we should use %20.
diff --git a/sources/net.sf.j2s.java.core/src/javajs/http/SimpleHttpClient.java b/sources/net.sf.j2s.java.core/src/javajs/http/SimpleHttpClient.java
@@ -322,12 +322,15 @@ private Response fulfillGet(Response r) throws IOException {
 
 		private String encodeURI(String value) {
 			try {
+				// convert " " to "%20", not "+"
+				// based on https://stackoverflow.com/questions/2678551/when-to-encode-space-to-plus-or-20
+				// Answer # 46. and "URI Generic Syntax " https://tools.ietf.org/html/rfc3986
+				// This will be consistent, then, with JavaScript encodeURIComponent().
 				return URLEncoder.encode(value.replace(' ', '\0'), "UTF-8").replaceAll("%00", "%20");
 			} catch (UnsupportedEncodingException e) {
 				// impossible
+				return null;
 			}
-			
-			return null;
 		}
 
 		private Response fulfillPost(Response r) throws IOException {
diff --git a/sources/net.sf.j2s.java.core/src/test/Test_URL.java b/sources/net.sf.j2s.java.core/src/test/Test_URL.java
@@ -17,6 +17,7 @@
 import java.net.URI;
 import java.net.URL;
 import java.net.URLConnection;
+import java.net.URLEncoder;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -54,7 +55,10 @@ protected static String getResponseMimeType() {
 	public static void main(String[] args) {
 
 		try {
-
+			String value = "this is a test+this";
+			String s = URLEncoder.encode(value.replace(' ', '\0'), "UTF-8").replaceAll("%00", "%20");
+			System.out.println(s);
+			
 			testPost2();
 
 			// jar:file:C:/temp/car.trz!/Car in a loop with friction.trk
