java2script
diff --git a/‎sources/net.sf.j2s.java.core/src/swingjs/plaf/ButtonListener.java‎
Lines changed: 1 addition & 0 deletions b/‎sources/net.sf.j2s.java.core/src/swingjs/plaf/ButtonListener.java‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎sources/net.sf.j2s.java.core/src/swingjs/plaf/JSComponentUI.java‎
Lines changed: 6 additions & 5 deletions b/‎sources/net.sf.j2s.java.core/src/swingjs/plaf/JSComponentUI.java‎
Lines changed: 6 additions & 5 deletions
diff --git a/‎sources/net.sf.j2s.java.core/src/swingjs/plaf/JSSliderUI.java‎
Lines changed: 6 additions & 4 deletions b/‎sources/net.sf.j2s.java.core/src/swingjs/plaf/JSSliderUI.java‎
Lines changed: 6 additions & 4 deletions
@@ -29,6 +29,7 @@
 package swingjs.plaf;
 
 import java.awt.Container;
+import java.awt.JSComponent;
 import java.awt.event.ActionEvent;
 import java.awt.event.FocusEvent;
 import java.awt.event.FocusListener;
 
@@ -1222,18 +1222,18 @@ public void setTainted(boolean tf) {
 	public void stateChanged(ChangeEvent e) {
 	}
 
-	private void updatePropertyAncestor(boolean fromButtonListener) {
+	private void updatePropertyAncestor(boolean andSetHTML) {
 		// Q: Why is setTainted() within fromButtonListener -- here only, not below?
-		if (fromButtonListener) {
-			setTainted();
+		setTainted();
+		if (andSetHTML) {
 			setHTMLElement();
 		}
 		JComponent p = (JComponent) jc.getParent();
 		while (p != null) {
 			JSComponentUI parentui = (p == null ? null : p.秘getUI());
 			if (parentui != null) {
 				parentui.setTainted();
-				if (fromButtonListener) {
+				if (andSetHTML) {
 					parentui.setHTMLElement();
 					if (parentui.menu != null) {
 						((JSPopupMenuUI) parentui).updateMenu(false);
@@ -1308,7 +1308,8 @@ void propertyChangedFromListener(PropertyChangeEvent e, String prop) {
 		case "ancestor":
 			if (cellComponent != null)
 				return;
-			updatePropertyAncestor(true);
+			Container anc = JSComponent.秘getTopInvokableAncestor(c, false);
+			updatePropertyAncestor(anc != null && anc.isVisible());
 			break;
 		}
 		propertyChangedCUI(e, prop);
 
@@ -118,7 +118,7 @@ public DOMNode updateDOMNode() {
 			setTainted();
 			setInnerComponentBounds(jc.getWidth(), jc.getHeight());
 		}
-		setup(isNew || isChanged);
+ 		setup(isNew || isChanged);
 		setSlider();
 		setBackground(getBackground());
 		setForeground(getForeground());
@@ -324,7 +324,7 @@ protected void setSliderAttr(String key, float val) {
 		 *  jsslider.j2sslider("option",key,val);
 		 */
 		} catch (Throwable t) {
-			System.out.println(key + ":" + val + " could not be set for " + id);
+			// System.out.println(key + ":" + val + " could not be set for " + id);
 			// ignore -- disposal problem?
 		}
 		noSnapping = isScrollBar;
@@ -490,7 +490,7 @@ public void stateChanged(ChangeEvent e) {
 
 
 	void setScrollBarExtentAndCSS() {
-		// scrollbar subclass only
+		// overridden in JSScrollBarUI
 	}
 
 
@@ -532,7 +532,7 @@ public Dimension getPreferredHorizontalSize() {
 	public Dimension getPreferredVerticalSize() {
 		Dimension vertDim = (Dimension) DefaultLookup.get(slider, this,
 				"Slider.verticalSize");
-		return new Dimension(Math.max(vertDim.height, myHeight), vertDim.width);
+		return new Dimension(Math.max(vertDim.width, myHeight), vertDim.height);
 	}
 
 	/**
@@ -645,6 +645,8 @@ protected void setJSDimensions(int width, int height) {
 		} else {
 			DOMNode.setStyles(domNode, "left", ((width - myHeight) / 2) + "px", "width", myHeight + "px");
 		}
+		if (!isScrollBar)
+			setSlider();
 	}
 
 //	@Override