Skip to content

Commit 3ebec89

Browse files
committed
predefined package names that cannot be var names
1 parent 8ad84ec commit 3ebec89

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

sources/net.sf.j2s.core/src/net/sf/j2s/core/astvisitors/ASTScriptVisitor.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,8 +642,10 @@ private void addMethodArgument(Expression exp, String clazzName, String methodNa
642642
}
643643
ITypeBinding expTypeBinding = exp.resolveTypeBinding();
644644
String expTypeName = (expTypeBinding == null ? null : expTypeBinding.getName());
645-
if (expTypeBinding == null)
645+
if (expTypeBinding == null) {
646646
System.err.println("typeBinding was null in " + clazzName + "." + methodName + " " + parameterTypeName + " " + exp);
647+
return;
648+
}
647649
// BH: Question: When does typeBinding == null?
648650
// only continue if we are converting a character to a non-character type
649651
// Keep String#indexOf(int) and String#lastIndexOf(int)'s first char argument

sources/net.sf.j2s.core/src/net/sf/j2s/core/astvisitors/DependencyASTVisitor.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,13 +384,15 @@ public boolean visit(PackageDeclaration node) {
384384

385385

386386

387+
private String[] defaultPackageNamesDefined = {"java", "javax", "sun", "jsjava", "jsjavax", "jssun"};
387388
private void addPackage(String name) {
388389
int pt = name. indexOf(".");
389390
if (pt >= 0)
390391
name = name.substring(0, pt);
391392
if (definedBasePackageNames == null) {
392393
definedBasePackageNames = new HashSet<String>();
393-
definedBasePackageNames.add("java");
394+
for (int i = defaultPackageNamesDefined.length; --i >= 0;)
395+
definedBasePackageNames.add(defaultPackageNamesDefined[i]);
394396
}
395397
if (definedBasePackageNames.add(name)) {
396398
System.err.println("adding package " + name);

0 commit comments

Comments
 (0)