Quality: add unit test

abego · abego · commit 25afd1d47d41 · 2017-06-30T13:04:08.000+02:00
A call in a superclass constructor to a private method ("baz") does
not run a (public) subclass method with the same signature but the
method in the superclass.
diff --git a/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/basic/AllBasicTests.java b/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/basic/AllBasicTests.java
@@ -18,7 +18,7 @@
 public class AllBasicTests extends TestCase {
 	
 	public static Test suite() {
-		TestSuite suite = new TestSuite("Kernel");
+		TestSuite suite = new TestSuite("All Basic Tests");
 
 		suite.addTestSuite(FieldInitTest.class);
 		suite.addTestSuite(OverloadTest.class);
diff --git a/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/basic/OverloadTest.java b/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/basic/OverloadTest.java
@@ -82,7 +82,7 @@ public void testOverloadedConstructorBoolean() {
 
 		new C(true);
 
-		assertEquals("C(true)\n", Output.text());
+		assertEquals("C(true)\nC.baz()\n", Output.text());
 	}
 	
 	
diff --git a/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/basic/SubclassTest.java b/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/basic/SubclassTest.java
@@ -27,6 +27,19 @@ public void testSuperClassConstructorCallsOverridingMethod() {
 		new C1();
 		assertEquals("C()\nC1.foo()\nC.bar()\nC1()\n", Output.text());
 	}
+	
+	/**
+	 * A call in a superclass constructor to a private method ("baz") does 
+	 * not run a (public) subclass method with the same signature but the
+	 * method in the superclass.
+	 *  
+	 */
+	public void testSuperClassConstructorCallsPrivatePseudoOverriddenMethod() {
+		Output.clear();
+
+		new C1(true);
+		assertEquals("C(true)\nC.baz()\nC1(true)\nC1.baz()\n", Output.text());
+	}
 }
 
 
diff --git a/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/sample/C.java b/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/sample/C.java
@@ -43,6 +43,7 @@ public C(double n) {
 
 	public C(boolean b) {
 		Output.add("C("+b+")\n");
+		baz();
 	}
 
 	public void foo() {
@@ -52,4 +53,8 @@ public void foo() {
 	public void bar() {
 		Output.add("C.bar()\n");
 	}
+	
+	private void baz() {
+		Output.add("C.baz()\n");
+	}
 }
diff --git a/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/sample/C1.java b/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/sample/C1.java
@@ -19,8 +19,18 @@ public C1() {
 		Output.add("C1()\n");
 	}
 
+	public C1(boolean b) {
+		super(b);
+		Output.add("C1("+b+")\n");
+		baz();
+	}
+
 	public void foo() {
 		Output.add("C1.foo()\n");
 	}
 
+	public void baz() {
+		Output.add("C1.baz()\n");
+	}
+
 }

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public void testOverloadedConstructorBoolean() {`
`82`	`82`
`83`	`83`	`new C(true);`
`84`	`84`
`85`		`- assertEquals("C(true)\n", Output.text());`
	`85`	`+ assertEquals("C(true)\nC.baz()\n", Output.text());`
`86`	`86`	`}`
`87`	`87`
`88`	`88`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ public C(double n) {`
`43`	`43`
`44`	`44`	`public C(boolean b) {`
`45`	`45`	`Output.add("C("+b+")\n");`
	`46`	`+ baz();`
`46`	`47`	`}`
`47`	`48`
`48`	`49`	`public void foo() {`
`@@ -52,4 +53,8 @@ public void foo() {`
`52`	`53`	`public void bar() {`
`53`	`54`	`Output.add("C.bar()\n");`
`54`	`55`	`}`
	`56`	`+`
	`57`	`+ private void baz() {`
	`58`	`+ Output.add("C.baz()\n");`
	`59`	`+ }`
`55`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,18 @@ public C1() {`
`19`	`19`	`Output.add("C1()\n");`
`20`	`20`	`}`
`21`	`21`
	`22`	`+ public C1(boolean b) {`
	`23`	`+ super(b);`
	`24`	`+ Output.add("C1("+b+")\n");`
	`25`	`+ baz();`
	`26`	`+ }`
	`27`	`+`
`22`	`28`	`public void foo() {`
`23`	`29`	`Output.add("C1.foo()\n");`
`24`	`30`	`}`
`25`	`31`
	`32`	`+ public void baz() {`
	`33`	`+ Output.add("C1.baz()\n");`
	`34`	`+ }`
	`35`	`+`
`26`	`36`	`}`