Bug: warning "Null pointer access: The variable action can only be null at this location"

abego · abego · commit 16df8f4844bb · 2017-06-22T18:54:55.000+02:00
diff --git a/sources/net.sf.j2s.ui/src/net/sf/j2s/ui/console/J2SViewImages.java b/sources/net.sf.j2s.ui/src/net/sf/j2s/ui/console/J2SViewImages.java
@@ -39,6 +39,9 @@ public class J2SViewImages {
 
 	public static void setImageDescriptors(IAction action, String type) {
 		if (action == null) {
+			return;
+		}
+		
 		try {
 			ImageDescriptor id= ImageDescriptor.createFromURL(makeIconFileURL("d", type)); //$NON-NLS-1$
 			if (id != null)
@@ -52,7 +55,7 @@ public static void setImageDescriptors(IAction action, String type) {
 				action.setHoverImageDescriptor(id);
 		} catch (MalformedURLException e) {
 		}
-		}
+		
 		action.setImageDescriptor(create("e", type)); //$NON-NLS-1$
 	}
 	
