Skip to content

Mark no file with /dev/null to align with git diff - #93

Merged
wumpz merged 1 commit into
java-diff-utils:masterfrom
MTelling:patch-1
Aug 4, 2020
Merged

Mark no file with /dev/null to align with git diff#93
wumpz merged 1 commit into
java-diff-utils:masterfrom
MTelling:patch-1

Conversation

@MTelling

@MTelling MTelling commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

If you run git diff locally with a staged new file the diff will indicate that the file did not exist before with --- /dev/null.
I believe this should align with that?

If you run git diff locally with a staged new file the diff will indicate that the file did not exist before with `--- /dev/null`.
I believe this should align with this?
@wumpz
wumpz merged commit d352431 into java-diff-utils:master Aug 4, 2020
@wumpz

wumpz commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

Merged a bit to fast. You should adapt running tests before you make a pull request. I do it for this one.

@MTelling

MTelling commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

Merged a bit to fast. You should adapt running tests before you make a pull request. I do it for this one.

@wumpz Oh yeah, sorry! Will do next time - Too used to having CI around...

@MTelling
MTelling deleted the patch-1 branch August 4, 2020 10:54
@MTelling

MTelling commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

@wumpz opened PR #94 to fix the test.

wumpz added a commit that referenced this pull request Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants