Deduplicate string building logic in Customization

Tamas Balog · Tamas Balog · commit 7a4b0821039d · 2017-02-17T20:22:54.000+01:00
diff --git a/src/main/java/org/skyscreamer/jsonassert/Customization.java b/src/main/java/org/skyscreamer/jsonassert/Customization.java
@@ -24,18 +24,7 @@ private String buildPatternLevel1(String path) {
 		String regex = "\\*\\*\\.";
 		String replacement = "(?:.+\\.)?";
 
-		StringBuilder sb = new StringBuilder();
-		String[] parts = path.split(regex);
-		for (int i = 0; i < parts.length; i++) {
-			String part = parts[i];
-
-			sb.append(buildPatternLevel2(part));
-			if (i < parts.length - 1) {
-				sb.append(replacement);
-			}
-		}
-
-		return sb.toString();
+		return buildPattern(path, regex, replacement, 1);
 	}
 
 	private String buildPatternLevel2(String s) {
@@ -45,17 +34,7 @@ private String buildPatternLevel2(String s) {
 		String regex = "\\*\\*";
 		String replacement = ".+";
 
-		StringBuilder sb = new StringBuilder();
-		String[] parts = s.split(regex);
-		for (int i = 0; i < parts.length; i++) {
-			String part = parts[i];
-
-			sb.append(buildPatternLevel3(part));
-			if (i < parts.length - 1) {
-				sb.append(replacement);
-            }
-        }
-		return sb.toString();
+		return buildPattern(s, regex, replacement, 2);
 	}
 
 	private String buildPatternLevel3(String s) {
@@ -66,19 +45,41 @@ private String buildPatternLevel3(String s) {
 		String regex = "\\*";
 		String replacement = "[^\\.]+";
 
+		return buildPattern(s, regex, replacement, 3);
+	}
+
+	private String buildPattern(String path, String regex, String replacement, int level) {
 		StringBuilder sb = new StringBuilder();
-		String[] parts = s.split(regex);
+		String[] parts = path.split(regex);
 		for (int i = 0; i < parts.length; i++) {
-			String part = parts[i];
-
-			sb.append(Pattern.quote(part));
+			sb.append(buildPatternForLevel(level, parts[i]));
 			if (i < parts.length - 1) {
 				sb.append(replacement);
-            }
-        }
+			}
+		}
 		return sb.toString();
 	}
 
+	private String buildPatternForLevel(int level, String part) {
+		switch (level) {
+			case 1:
+				return buildPatternLevel2(part);
+			case 2:
+				return buildPatternLevel3(part);
+			case 3:
+				return Pattern.quote(part);
+			default:
+				return "Incorrect level.";
+		}
+	}
+
+	/**
+	 * Creates a new {@link Customization} instance for {@code path} and {@code comparator}.
+	 *
+	 * @param path the json path
+	 * @param comparator the comparator
+	 * @return a new Customization
+	 */
 	public static Customization customization(String path, ValueMatcher<Object> comparator) {
 		return new Customization(path, comparator);
 	}
