Jasyn Marais - JavaScript IV #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedssoft
approved these changes
Oct 18, 2019
| return `${student.name} receives a perfect score on ${subject}`; | ||
| } | ||
| randGrade(student) { // stretch | ||
| student.grade = Number(student.grade); |
Collaborator
There was a problem hiding this comment.
No need mutating the object, you could create a new variable off of the student object, e.g let studentGrade = Number(student.grade)
| } | ||
| listSubjects() { | ||
| console.log(`${this.name} favourite subjects: ${this.favSubjects}`); | ||
| return `${this.name} favourite subjects: ${this.favSubjects}`; |
Collaborator
There was a problem hiding this comment.
favSubjects is an array, to make it a list separated by a comma, you could use, this.favSubjects.join(',')
Comment on lines
+47
to
+53
| drive(distance) { | ||
| if (this.canDrive) { | ||
| this.odometer += Number(distance); | ||
| return `Drove ${distance} miles. Odometer: ${this.odometer}.`; | ||
| } | ||
| return `I crashed at ${this.odometer} miles!`; | ||
| } |
Collaborator
There was a problem hiding this comment.
This does not conform with the instruction/spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.