Skip to content

SSLMode support for MysqlConnectionFactoryProvider#349

Merged
oshai merged 1 commit intojasync-sql:masterfrom
tkurylek:feature/r2dbc-mysql-ssl-mode-support
Jan 12, 2023
Merged

SSLMode support for MysqlConnectionFactoryProvider#349
oshai merged 1 commit intojasync-sql:masterfrom
tkurylek:feature/r2dbc-mysql-ssl-mode-support

Conversation

@tkurylek
Copy link
Copy Markdown

@tkurylek tkurylek commented Jan 2, 2023

This PR fixes #337

@tkurylek tkurylek force-pushed the feature/r2dbc-mysql-ssl-mode-support branch from f820caa to 6542087 Compare January 2, 2023 12:46
@tkurylek
Copy link
Copy Markdown
Author

tkurylek commented Jan 9, 2023

@oshai The MysqlSSLConfigurationFactoryTest passes locally on my machine (via ./gradlew clean build). Do you know why the PR fails here: https://github.com/jasync-sql/jasync-sql/actions/runs/3822628348/jobs/6507771842 ?

@oshai
Copy link
Copy Markdown
Contributor

oshai commented Jan 10, 2023

I will check locally once I get to it.

@oshai
Copy link
Copy Markdown
Contributor

oshai commented Jan 12, 2023

I just run it again and it passed. It looks something is flaky, hope will get to investigate it later.

@oshai oshai merged commit 613b46d into jasync-sql:master Jan 12, 2023
@oshai
Copy link
Copy Markdown
Contributor

oshai commented Jan 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSL Mode support for MySQL

2 participants