Skip to content

Conversation

@oshai
Copy link
Contributor

@oshai oshai commented Apr 14, 2019

No description provided.

@oshai
Copy link
Contributor Author

oshai commented Apr 14, 2019

This PR is for issue #106

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #116 into master will decrease coverage by 0.07%.
The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #116      +/-   ##
============================================
- Coverage     78.94%   78.87%   -0.08%     
  Complexity     1011     1011              
============================================
  Files           258      258              
  Lines          3662     3673      +11     
  Branches        487      490       +3     
============================================
+ Hits           2891     2897       +6     
- Misses          531      535       +4     
- Partials        240      241       +1
Impacted Files Coverage Δ Complexity Δ
...hub/jasync/sql/db/util/ChannelFutureTransformer.kt 65% <44.44%> (-18.34%) 0 <0> (ø)
...async/sql/db/mysql/codec/MySQLConnectionHandler.kt 78.72% <85.71%> (+0.34%) 57 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e168f4...e55e570. Read the comment docs.

@oshai
Copy link
Contributor Author

oshai commented Apr 16, 2019

@mp911de - can you please take a look and let me know if this is how it is supposed to be implemented?

@mp911de
Copy link
Contributor

mp911de commented Apr 16, 2019

Sure. You're heading in a good direction. We added a bit of documentation to R2DBC SPI about exceptions: https://github.com/r2dbc/r2dbc-spi/blob/master/r2dbc-spec/src/main/asciidoc/exceptions.adoc

You might also have a look at what I did for SQL Server: r2dbc/r2dbc-mssql@8c89765

It's basically reflecting various errors with most appropriate exception types to indicate what's going wrong.

@oshai oshai marked this pull request as ready for review May 15, 2019 08:47
@oshai oshai merged commit 13d8de7 into master May 15, 2019
@oshai oshai deleted the r2dbcexceptions branch May 15, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants