Skip to content
This repository was archived by the owner on Oct 9, 2019. It is now read-only.
This repository was archived by the owner on Oct 9, 2019. It is now read-only.

getsinglemarketdata (Api.market_data(marketid=<int>)) error handling #8

@jaapz

Description

@jaapz

When getsinglemarketdata errors, it returns a succesfull=1 while something went wrong, giving the user a wrong impression about the succesfullness of the request.

Possible fixes:

  • if API returns a False, but succesful is set to 1, set it back to 0 and return that to the user (hackish, but works)
  • throw an exception when the API returns a False (nicer, IMHO)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions