Skip to content

Validators: clean up links with :443 port in it #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iparamonau merged 2 commits into from
Dec 15, 2025
Merged

Validators: clean up links with :443 port in it #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d952143
Validators: clean up links with `:443` port in it
iparamonau Dec 15, 2025
444e9e6
cleanup
iparamonau Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/plugins/validators/sync/04_ssl_validator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,9 @@ export default {
if (sslProtocol && !hasSSL) {
link.rel.push('ssl');
}

if (/^https:\/\/[^\/\?]+:443\/?/.test(link.href)) {
link.href = link.href.replace(/^(https:\/\/[^\/\?]+):443/, '$1');
}
}
};
2 changes: 2 additions & 0 deletions lib/plugins/validators/sync/01_ignorelist.js → lib/plugins/validators/sync/05_ignorelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
export default {

// Should go after 04_sll_validator that replaces ":443" with ''

prepareLink: function(whitelistRecord, options, link, plugin) {

if (!link.error
Expand Down
2 changes: 1 addition & 1 deletion plugins/domains/instagram.com/instagram.com.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default {
// Remove below error when and if it's fixed. Validators will remove the link
og_image.error = 'Unfortunatelly Instagram\'s OG image is cropped';
} else if (!oembed.thumbnail_url) {
og_image.message = "Unfortunatelly, Instagram removed full images on November 3, 2025";
// og_image.message = "Unfortunatelly, Instagram removed full images on November 3, 2025"; // images seem to be OK as of Dec 12, 2025
}
links.push(og_image);
}
Expand Down