[Domains] Fix Bunny CDN autoplay issues via Twitter Player domain flags

iparamonau · iparamonau · commit 2e7e71be8885 · 2025-12-05T12:44:54.000-05:00
diff --git a/lib/plugins/validators/sync/06_autoplay.js b/lib/plugins/validators/sync/06_autoplay.js
@@ -27,7 +27,17 @@ export default {
             // don't need this field any longer
             delete link.autoplay;
             
-            if (link.href.indexOf(play) > -1 || link.rel.indexOf(CONFIG.R.autoplay) == -1) {
+            /**
+             * Three cases: 
+             *  1) Link does not autoplay by default. We need to add an autoplay with autoplay=1.
+             *  2) Link autoplays:
+             *   - with autoplay=1 in src, maybe with no autoplay in rels
+             *   - or without autoplay=1 in src, but autoplay in rels
+             *  We need to add a non-autoplaying variant with autoplay=0
+             */
+            if ((link.href.indexOf(play) === -1 && link.rel.indexOf(CONFIG.R.autoplay) === -1)
+                || link.href.indexOf(play) > -1
+                || link.rel.indexOf(CONFIG.R.autoplay) > -1) {
 
                var stop = play.replace(/\=(\w+)/, function (p1, p2) {
                     var antonyms = {
@@ -39,37 +49,47 @@ export default {
                         'off': 'on'
                     };
                     return '=' + antonyms[p2];
-                });                
+                });
 
-                var rels = [...link.rel]; 
+                const rel = link.rel;
+                const RELS = [...rel];
+                RELS.splice(link.rel.indexOf(CONFIG.R.autoplay), 1);
+                delete link.rel;
+
+                const RELS_WITH_AUTOPLAY = [...RELS, CONFIG.R.autoplay];
                 var new_link = Object.assign({}, link);
-                new_link.rel = rels; // deep copy
 
+                if (link.href.indexOf(play) > -1 ) {
 
-                if (link.href.indexOf(play) > -1 ) { 
-                    // original link is autoplay
-                    if (link.rel.indexOf(CONFIG.R.autoplay) == -1 ) {
-                        link.rel.push(CONFIG.R.autoplay);
-                    }
-                    
+                    // Original link is autoplay
+                    link.rel = RELS_WITH_AUTOPLAY;
+
+                    // Add a link without autoplay
                     new_link.href = new_link.href.replace(play, stop);
-                    if (new_link.rel.indexOf(CONFIG.R.autoplay) > -1 ) {
-                        new_link.rel.splice(new_link.rel.indexOf(CONFIG.R.autoplay), 1);
-                    }
+                    new_link.rel = RELS;
 
-                } else if (link.rel.indexOf(CONFIG.R.autoplay) == -1) { 
+                } else if (/* link.href.indexOf(play) === -1 && */ rel.indexOf(CONFIG.R.autoplay) > -1 ) {
 
-                    // original link isnt autoplay, leave it alone
-                    // autoplay=false may autoplay. Many publishers react to any `autoplay` value
+                    link.rel = RELS_WITH_AUTOPLAY;
 
+                    // link.href.indexOf(play) === -1, no need to double-check
+                    // Add a link without autoplay
+                    new_link.href += (new_link.href.indexOf('?') > -1 ? '&' : '?') + stop;
+                    new_link.rel = RELS;
+
+                } else if (rel.indexOf(CONFIG.R.autoplay) === -1) { 
+
+                    // Original link isnt autoplay, leave it as is
+                    link.rel = RELS;
+
+                    // Add a link with autoplay
                     if (link.href.indexOf(stop) > -1) {
                         new_link.href = new_link.href.replace(stop, play);
                     } else  {
-                        new_link.href += (new_link.href.indexOf('?') > -1 ? '&' : '?') + play;    
+                        new_link.href += (new_link.href.indexOf('?') > -1 ? '&' : '?') + play;
                     }
                     
-                    new_link.rel.push(CONFIG.R.autoplay);
-
+                    new_link.rel = RELS_WITH_AUTOPLAY;
                 }
 
                 return {
