Convert core/edge to plasma IDS#87
Conversation
Expose additional API as "public" in the main `imas` space and update the Public API page accordingly.
maarten-ic
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
I might have just forgotten to implement that, but don't recall to be honest. |
|
Yes please do add it directly there, it will help some users while testing it, and we can amend it later once the DD is updated with new identitiers |
| ) | ||
|
|
||
| # Convert to plasma_profiles/plasma_sources/plasma_transport IDS | ||
| if convert_to_plasma_ids and ids_name.startswith(("core", "edge")): |
There was a problem hiding this comment.
I guess this test shall be improved, currently it will get also the core_instant_changes IDS (still have to find a data-entry with such IDS).
Otherwise it looks good to me, but I'm waiting an answer to iterorganization/IMAS-Data-Dictionary#191 before approving.
There was a problem hiding this comment.
Sharp, I didn't think of that indeed! I'll update the logic
…-convert-to-plasma-ids`
olivhoenen
left a comment
olivhoenen
left a comment
There was a problem hiding this comment.
All good now with DD 4.1.1 fix on coordinates
3 participants
Fixes #44