Skip to content

Project Drum Kit #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isvictorious wants to merge 4 commits into
base: victor
Choose a base branch
from
Open

Project Drum Kit #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df75ac2
first project
isvictorious Jul 21, 2019
4b701f4
completed 30 minutes of drumkit
isvictorious Jul 24, 2019
1f37683
added class & play audio on key press
isvictorious Jul 30, 2019
c811e91
updated drum kit
isvictorious Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions 01 - JavaScript Drum Kit/index-START.html → 01 - JavaScript Drum Kit/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@

<div class="keys">
<div data-key="65" class="key">
<kbd>A</kbd>
<kbd>!</kbd>
<span class="sound">clap</span>
</div>
<div data-key="83" class="key">
<kbd>S</kbd>
<kbd>J</kbd>
<span class="sound">hihat</span>
</div>
<div data-key="68" class="key">
Expand Down Expand Up @@ -58,9 +58,25 @@
<audio data-key="76" src="sounds/tink.wav"></audio>

<script>
// X log keys pressed to console
// X log data-key to console
// X Add class of playing to div by key #
// X Add audio.play
document.addEventListener('keydown', logKey);

function logKey(e) {
const currentKey = e.keyCode;
console.log(currentKey);
let playNow = document.querySelector(`audio[data-key="${currentKey}"]`);
let keyFront = document.querySelector(`div[data-key="${currentKey}"]`);
keyFront.classList.add("playing");
playNow.play()

}

</script>



</body>
</html>
4 changes: 4 additions & 0 deletions 02 - JS and CSS Clock/index-START.html → 02 - JS and CSS Clock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@
</style>

<script>
// get current time
// ? rotate hand based on time
// transform: rotate(Xdeg);
// transofmr: origin


</script>
Expand Down
2 changes: 2 additions & 0 deletions 03 - CSS Variables/index-START.html → 03 - CSS Variables/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ <h2>Update CSS Variables with <span class='hl'>JS</span></h2>
</style>

<script>
// update variables with JS!

</script>

</body>
Expand Down
0 04 - Array Cardio Day 1/index-START.html → 04 - Array Cardio Day 1/index.html
View file
Open in desktop
File renamed without changes.