Skip to content

First Attempt! Got stuck at getting the keys to make sounds #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dkinguag wants to merge 2 commits into
base: master
Choose a base branch
from
Open

First Attempt! Got stuck at getting the keys to make sounds #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ea951
First Attempt! Got stuck at getting the keys to make sounds
Dkinguag Jul 24, 2019
7c82ff5
Basically Finished. I have to tweak a few things.
Dkinguag Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions 01 - JavaScript Drum Kit/index-START.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,22 @@
<audio data-key="76" src="sounds/tink.wav"></audio>

<script>
window.addEventListener('keydown', function (e) {
const audio = document.querySelector(`audio[data-key="${e.keyCode}"]`);
const key = document.querySelector(`.key[data-key="${e.keyCode}"]`);
if (!audio) return; //stops the function all together
audio.currentTime = 0; //rewind to the start
audio.play();
key.classList.add('playing');
});

function removeTransition(e) {
if ( e.propertyName !== 'transform' ) return; //skip if its not a transform
this.classList.remove('playing');
}

const keys = document.querySelectorAll('.key');
keys.forEach(key => key.addEventListener('transitionend', removeTransition));

</script>

Expand Down