Conversation
|
Can you explain why do you need NPM workspaces in this project? I have no idea what you're doing. |
|
Also, I'm not going to review 40k lines of code where you changed formatting. If you want to contribute to this project, please don't reformat the whole codebase. |
|
@jcubic ya that was why i did not contribute the last 5 years i guess this project is dead because of its repo structures and pipelines. used eg: webpack 4 2020-10-10 All this code is so old that only some one like me with over 30 years of experience does understand what happened here this repo has so much old legacy bloat that was needed in the past but got fixed upstream. Thx anyway i will hardfork this and go under a new name i will use @awesome-os/isomorphic-git and will start with version 4 as you will never reach a version 4 that is total save. And i am willing to review 1 Mio lines of code if needed thats why tooling exists. Closing the Eyes does not help |
This PR is part of: #2151
I'm fixing a bug or typo
npm run add-contributorand follow the prompts to add yourself to the READMEI'm adding a parameter to an existing command X:
src/api/X.js(andsrc/commands/X.jsif necessary)__tests__/test-X.jsif possiblenpm run add-contributorand follow the prompts to add yourself to the READMEI'm adding a new command:
src/api(andsrc/commandsif necessary)src/index.js__tests__/test-exports.jssrc/__tests__website/sidebars.jsonwebsite/versioned_sidebars/version-1.x-sidebars.jsonnpm run add-contributorand follow the prompts to add yourself to the README