Skip to content

(WiP) Npm workspaces#2154

Open
lemanschik wants to merge 7 commits intoisomorphic-git:mainfrom
awesome-os:npm-workspaces
Open

(WiP) Npm workspaces#2154
lemanschik wants to merge 7 commits intoisomorphic-git:mainfrom
awesome-os:npm-workspaces

Conversation

@lemanschik
Copy link

This PR is part of: #2151

I'm fixing a bug or typo

  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "fix: [Description of fix]"

I'm adding a parameter to an existing command X:

  • add parameter to the function in src/api/X.js (and src/commands/X.js if necessary)
  • document the parameter in the JSDoc comment above the function
  • add a test case in __tests__/test-X.js if possible
  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README

I'm adding a new command:

  • add as a new file in src/api (and src/commands if necessary)
  • add command to src/index.js
  • update __tests__/test-exports.js
  • create a test in src/__tests__
  • document the command with a JSDoc comment
  • add page to the Docs Sidebar website/sidebars.json
  • add page to the v1 Docs Sidebar website/versioned_sidebars/version-1.x-sidebars.json
  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "feat: Added 'X' command"

@jcubic
Copy link
Member

jcubic commented Aug 18, 2025

Can you explain why do you need NPM workspaces in this project? I have no idea what you're doing.

@jcubic
Copy link
Member

jcubic commented Aug 18, 2025

Also, I'm not going to review 40k lines of code where you changed formatting.

If you want to contribute to this project, please don't reformat the whole codebase.

@lemanschik
Copy link
Author

lemanschik commented Aug 19, 2025

@jcubic ya that was why i did not contribute the last 5 years i guess this project is dead because of its repo structures and pipelines. used eg: webpack 4 2020-10-10
This is works out great we release webpack 5 at 2020-10-10 because it's a cool date.01.09.2020

All this code is so old that only some one like me with over 30 years of experience does understand what happened here this repo has so much old legacy bloat that was needed in the past but got fixed upstream.

Thx anyway i will hardfork this and go under a new name i will use @awesome-os/isomorphic-git and will start with version 4 as you will never reach a version 4 that is total save.

And i am willing to review 1 Mio lines of code if needed thats why tooling exists. Closing the Eyes does not help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants