Skip to content

Default profile - #964

Merged
minrk merged 3 commits into
ipython:masterfrom
takluyver:default-profile
Nov 2, 2011
Merged

minrk merged 3 commits into
ipython:masterfrom
takluyver:default-profile

Conversation

@takluyver

Copy link
Copy Markdown
Member

As discussed, this makes the default profile the same for Python 2 and 3.

Also includes a fix for a new test that was failing on Python 3.

@takluyver

Copy link
Copy Markdown
Member Author

Now also includes Min's fix so starting the qtconsole and specifying a different profile works properly (#939).

@minrk

minrk commented Nov 2, 2011

Copy link
Copy Markdown
Member

Looks good to me, thanks!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takluyver, when you get a chance, do you want to toss together a writeup of the py3compat stuff? The unicode_to_str, etc. is clear enough, but some of these would warrant a good doc, so we don't make you keep fixing our tests, etc. for py3 quite so often.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll put something together on the wiki.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this branch has been merged.

minrk added a commit that referenced this pull request Nov 2, 2011
Python 3 being fully supported, it is no longer relegated to a special profile.
Users of both Python 3 and Python 2 will now get the same default profile (history, config, etc.) in each.

Closes gh-939, fixing the profile directory and magic in the IPython kernel.
@minrk
minrk merged commit c3d885f into ipython:master Nov 2, 2011
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Python 3 being fully supported, it is no longer relegated to a special profile.
Users of both Python 3 and Python 2 will now get the same default profile (history, config, etc.) in each.

Closes ipythongh-939, fixing the profile directory and magic in the IPython kernel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants