"smart command mode" for ipdb (like pdb++). #9449

anntzer · 2016-05-09T20:35:37Z

If e.g. "c" is a variable currently visible, then "c" should print it
instead of running the "continue" Pdb command. This idea was first
implemented by pdb++.

It is possible to force the standard pdb behavior (bypass variable
checking) by prefixing the command with "!!", e.g. "!!c" to continue.

If e.g. "c" is a variable currently visible, then "c" should print it instead of running the "continue" Pdb command. This idea was first implemented by pdb++. It is possible to force the standard pdb behavior (bypass variable checking) by prefixing the command with "!!", e.g. "!!c" to continue.

takluyver · 2016-05-10T10:21:18Z

IPython/core/debugger.py

+        # with the same name exists.
+        cmd, arg, newline = super(Pdb, self).parseline(line)
+        if cmd in self.curframe.f_globals or cmd in self.curframe.f_locals:
+            return super(Pdb, self).parseline("!" + line)


So !... means to execute the line (after !) as regular Python code?

This is normal pdb behavior: link

Thanks for confirming :-)

takluyver · 2016-05-10T10:22:23Z

This looks reasonable to me. Pinging @gotcha for the external ipdb package - any thoughts on this?

takluyver · 2016-05-10T10:39:44Z

This seems to be causing a build hang on Python 2.7 on Travis, though. I restarted it, but the same happened again. Can you investigate?

anntzer · 2016-05-10T15:23:54Z

I didn't have any hangs, but did find another bug (super needs new-style classes, so be it). I also have some other failures in iptest utils which seem unrelated:

======================================================================
ERROR: Failure: ImportError (cannot import name json_clean)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/nose/loader.py", line 418, in loadTestsFromName
    addr.filename, addr.module)
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/IPython/utils/tests/test_jsonutil.py", line 14, in <module>
    from ..jsonutil import json_clean, encode_images
ImportError: cannot import name json_clean

======================================================================
ERROR: IPython.utils.tests.test_localinterfaces.test_load_ips
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/IPython/utils/tests/test_localinterfaces.py", line 12, in test_load_ips
    localinterfaces._load_ips.called = False
AttributeError: 'module' object has no attribute '_load_ips'

======================================================================
ERROR: Failure: ImportError (cannot import name EventfulList)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/nose/loader.py", line 418, in loadTestsFromName
    addr.filename, addr.module)
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/IPython/utils/tests/test_traitlets.py", line 18, in <module>
    from IPython.utils.traitlets import (
ImportError: cannot import name EventfulList
======================================================================
FAIL: IPython.utils.tests.test_shimmodule.test_shim_warning
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/antony/venvs/ipy2/lib/python2.7/site-packages/IPython/utils/tests/test_shimmodule.py", line 14, in test_shim_warning
    assert len(w) == 1
AssertionError: 
>>  assert len([<warnings.WarningMessage object at 0x7fb13d2c9d90>, <warnings.WarningMessage object at 0x7fb13d2c9c50>, <warnings.WarningMessage object at 0x7fb13d2c9890>, <warnings.WarningMessage object at 0x7fb13d2f6fd0>]) == 1
    assert issubclass([<warnings.WarningMessage object at 0x7fb13d2c9d90>, <warnings.WarningMessage object at 0x7fb13d2c9c50>, <warnings.WarningMessage object at 0x7fb13d2c9890>, <warnings.WarningMessage object at 0x7fb13d2f6fd0>][-1].category, ShimWarning)

takluyver · 2016-05-10T15:27:46Z

Those unrelated failures look like you may have a leftover test file from an older version of IPython.

takluyver · 2016-05-10T15:28:29Z

I'm surprised that making a new style class like that works: I would expect that the base class it inherits from would have to be new style as well for super() to work. Have you tested this manually in Python 2?

anntzer · 2016-05-10T16:08:53Z

I did, and you can see the tests passing too. I guess super just needs to find the superclass of the current class to work.

takluyver · 2016-05-10T16:29:47Z

Thanks. I'll give @gotcha a chance to have a look, but I think this is looking OK.

gotcha · 2016-05-10T16:56:25Z

ipdb does only wrap IPython, so I would be surprised if ipdb code impact this in any way.

takluyver · 2016-05-10T16:58:22Z

No, I don't think it should. But I thought you might want to have a look at it, since you probably use the debugger a fair bit :-)

This is a manual revert of PR ipython#9449 Closes ipythongh-10037 I don't think there's currently enough support for smart command mode to be worth adding a config option for it now. We can always add this later.

takluyver reviewed May 10, 2016
View reviewed changes

Make Pdb a new-style class...

7b8ae1d

takluyver added this to the 5.0 milestone May 20, 2016

takluyver merged commit c0f292b into ipython:master May 20, 2016

anntzer deleted the ipdb-smart-command branch May 20, 2016 23:03

takluyver mentioned this pull request Jun 14, 2016

Can't exit debug magic after using a completion #9611

Closed

takluyver mentioned this pull request Aug 31, 2016

Can't change variable values in debug mode (%debug magic) #9887

Closed

tcztzy mentioned this pull request Oct 25, 2016

override the emptyline method #10035

Closed

tkossak mentioned this pull request Oct 26, 2016

Python variables obscur ipdb commands #10037

Closed

takluyver mentioned this pull request Nov 9, 2016

Revert debugger 'smart command mode' #10050

Merged

anntzer mentioned this pull request Feb 8, 2017

Add 'v' binding in vi-navigation-mode to %edit (#10225) -- rollback or not? #10259

Closed

Uh oh!

"smart command mode" for ipdb (like pdb++). #9449

"smart command mode" for ipdb (like pdb++). #9449

Uh oh!

Conversation

anntzer commented May 9, 2016

Uh oh!

takluyver May 10, 2016

Choose a reason for hiding this comment

Uh oh!

anntzer May 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

takluyver May 10, 2016

Choose a reason for hiding this comment

Uh oh!

takluyver commented May 10, 2016

Uh oh!

takluyver commented May 10, 2016

Uh oh!

anntzer commented May 10, 2016

Uh oh!

takluyver commented May 10, 2016

Uh oh!

takluyver commented May 10, 2016

Uh oh!

anntzer commented May 10, 2016

Uh oh!

takluyver commented May 10, 2016

Uh oh!

gotcha commented May 10, 2016

Uh oh!

takluyver commented May 10, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anntzer May 10, 2016 •

edited

Loading