fixes for parallel caused by recent PRs #8100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
minrk
commented
Mar 20, 2015
minrk
commented
- Extract session buffers as memoryviews #7798 turned some bytes into memoryviews, causing a few copy calls to fail, since memoryviews are not copyable by default.
- allow_none=False for all trait types but Instance and Type #7708 caught a few unnecessary intiial assignments (that probably predated traitlets) in the launchers that can be removed.
ran afoul of allow_none default changes
by making a new memoryview Python doesn't support copying of memoryviews for some reason. also remove confusing `import deepcopy as copy`
Member
|
+1 |
takluyver
added a commit
that referenced
this pull request
Mar 22, 2015
fixes for parallel caused by recent PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.