Repository navigation
Conversation
QtShellChannelMixin incorrectly uses a callback approach to pass the kernel_info_reply message, e.g. self._handle_kernel_info_reply(msg) Qt kernels should emit Qt signals for this behaviour (as done elsewhere in the class). This is fixed as follows, e.g. self.kernel_info_reply.emit(msg)
Member
|
Thanks for the PR, Martin. I've actually just done a much bigger refactoring of this code in #7108, though, so this may not get merged. |
Author
|
Thanks @takluyver Saw #7108 just after I submitted this! Had a look over the code and |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QtShellChannelMixin incorrectly uses a callback approach to pass the
kernel_info_reply message, e.g.
self._handle_kernel_info_reply(msg)
Qt kernels should emit Qt signals for this behaviour (as done elsewhere
in the class). This is fixed as follows, e.g.
self.kernel_info_reply.emit(msg)
Relevant bug report: #6578