Skip to content

QtShellChannelMixin should emit kernel_info_reply signal not call it - #7142

Closed
mfitzp wants to merge 1 commit into
ipython:masterfrom
mfitzp:qt-kernel-info-reply-fix
Closed

mfitzp wants to merge 1 commit into
ipython:masterfrom
mfitzp:qt-kernel-info-reply-fix

Conversation

@mfitzp

@mfitzp mfitzp commented Dec 9, 2014

Copy link
Copy Markdown

QtShellChannelMixin incorrectly uses a callback approach to pass the
kernel_info_reply message, e.g.

self._handle_kernel_info_reply(msg)

Qt kernels should emit Qt signals for this behaviour (as done elsewhere
in the class). This is fixed as follows, e.g.

self.kernel_info_reply.emit(msg)

Relevant bug report: #6578

QtShellChannelMixin incorrectly uses a callback approach to pass the
kernel_info_reply message, e.g.

   self._handle_kernel_info_reply(msg)

Qt kernels should emit Qt signals for this behaviour (as done elsewhere
in the class). This is fixed as follows, e.g.

   self.kernel_info_reply.emit(msg)
@takluyver

Copy link
Copy Markdown
Member

Thanks for the PR, Martin. I've actually just done a much bigger refactoring of this code in #7108, though, so this may not get merged.

@mfitzp

mfitzp commented Dec 9, 2014

Copy link
Copy Markdown
Author

Thanks @takluyver Saw #7108 just after I submitted this! Had a look over the code and QtShellChannelMixin looks to be absent in the new implementation so feel free to close this PR (and the bug). It'll be great to get this refactoring in 3.0.

@takluyver

Copy link
Copy Markdown
Member

#7108 landed, so closing this one. Thanks again, @mfitzp .

@takluyver takluyver closed this Dec 11, 2014
@minrk minrk modified the milestone: no action Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants