Skip to content

Fixes for _display_banner when creating new qtconsole tabs - #7131

Merged
minrk merged 1 commit into
ipython:masterfrom
helenst:qtconsole-fix-new-tab
Dec 8, 2014
Merged

minrk merged 1 commit into
ipython:masterfrom
helenst:qtconsole-fix-new-tab

Conversation

@helenst

@helenst helenst commented Dec 8, 2014

Copy link
Copy Markdown
  • make sure _display_banner is set in FrontendWidget
  • make sure _display_banner flag is passed in from console app

initialising it in the widget's __init__ might be overkill but seemed safer.

ref: PR #7129

* make sure _display_banner is set in FrontendWidget
* make sure _display_banner flag is passed in from console app
@minrk

minrk commented Dec 8, 2014

Copy link
Copy Markdown
Member

Thanks!

minrk added a commit that referenced this pull request Dec 8, 2014
Fixes for _display_banner when creating new qtconsole tabs
@minrk
minrk merged commit ab3b078 into ipython:master Dec 8, 2014
@minrk minrk modified the milestone: 3.0 Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants