Repository navigation
%gui qt5 - #6496
Merged
Merged
%gui qt5#6496
Conversation
Member
|
Sorry, this will conflict with #5666. Can I ask you to redo it on top of that once it's merged? I think that's easier than rebasing that PR again. |
Contributor
Author
|
I will make it so... |
Member
|
Thanks :-) |
userzimmermann
force-pushed
the
master
branch
from
September 19, 2014 17:18
600f4f9 to
7db52a7
Compare
Contributor
Author
|
Made |
Member
|
Thanks, this is satisfyingly neat. There's a small problem that the app object will get registered under the name 'qt4', but that's because of something I missed in updating this API, so I'll merge this and fix that in a separate PR. |
takluyver
added a commit
that referenced
this pull request
Sep 19, 2014
takluyver
added a commit
to takluyver/ipython
that referenced
this pull request
Sep 19, 2014
This avoids a problem I noticed in ipythongh-6496, where a subclassed handler would have its application registered by the parent class under the wrong name.
Member
|
If you're interested in what I changed, see #6505. |
Contributor
Author
|
Yes I am. Thanks :) |
minrk
added a commit
to minrk/ipython
that referenced
this pull request
Oct 1, 2014
same as terminal IPython in ipython#6496 didn't need anything beyond register
minrk
added a commit
to minrk/ipython
that referenced
this pull request
Oct 1, 2014
same as terminal IPython in ipython#6496 didn't need anything beyond register
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
This avoids a problem I noticed in ipythongh-6496, where a subclassed handler would have its application registered by the parent class under the wrong name.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
same as terminal IPython in ipython#6496 didn't need anything beyond register
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just wanted a simple way to explicitly decide between a Qt5 and a Qt4 loop, so I added these few lines :)