support notebooks in %run#4452
Merged
Merged
Conversation
Member
|
Looks sensible to me. I think it should have a test, though. |
Member
Author
|
It certainly should. I'm not in a great rush, since everything should be waiting for the single-codebase PR. |
Member
|
Nice idea... and very useful, I think. |
Member
Member
|
minrk#9 has a commit to add .ipynb filename completion to %run |
Member
|
+1 once test added. |
Member
|
@minrk , I think this is just waiting for a test now. |
Member
Author
|
Sorry, forgot about it. Test should be there now. |
Simple enough - just generalized safe_exec_ipy a bit to support a sequence of cells rather than just one cell (the .ipy behavior). I think we have an issue open for this, but I can't seem to find it.
Member
|
We actually have a separate file, |
Member
Author
|
bah, that's my lazy searching. I'll move them, yes. |
Member
Author
|
test moved. |
Member
|
Great. Tests passing, and the code still looks good. Merging. |
Member
|
Actually - could you just add a quick whatsnew entry? |
Member
|
Lovely. Really merging now. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
support notebooks in %run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple enough - just generalized safe_exec_ipy a bit to support a sequence of cells rather than just one cell (the .ipy behavior).
I think we have an issue open for this, but I can't seem to find it. (closes #1675 -pi)