moved DummyMod to proper namespace to enable dill pickling#4186
moved DummyMod to proper namespace to enable dill pickling#4186takluyver merged 4 commits intoipython:masterfrom
Conversation
|
IIRC, the reason for
There's more discussion of the rationale in PRs #384 and #648. |
IPython/terminal/embed.py
Outdated
There was a problem hiding this comment.
We have dropped support for Python 2.6 in master, so please don't commit this change. IPython 2.0 will support Python 2.7 and 3.3+.
There was a problem hiding this comment.
That snuck in on me in the above pull request... sorry. I won't commit it.
…ibility)" This reverts commit 311acdf.
|
@takluyver: popped out the 2.6 compatibility changes as requested. PR #4186 is now just moving DummyMod to the module's namespace. Sorry was a bit thrown off since README.rst still states 2.6 compatible. I do remember vaguely the "drop 2.6" discussion from the dev mailing list. |
|
👍 Thanks Mike. We'll get the README updated. |
|
Thanks @mmckerns . I think this looks sound, but I'll take a few minutes to test it after lunch. |
IPython/core/interactiveshell.py
Outdated
There was a problem hiding this comment.
Could you expand the docstring a little, now that it's no longer in context? Something like "...for IPython's interactive module when a namespace must be assigned to the modules __dict__".
Also, stick the @undoc decorator on the class so that it doesn't appear in the autogenerated docs.
|
This works fine in my manual tests - with those couple of small doc changes, I'll merge it. |
|
updated as requested. nice working with you on this. |
|
Merging :-) |
moved DummyMod to proper namespace to enable dill pickling
moved DummyMod to proper namespace to enable dill pickling
enables pickling with dill, which worked in 0.13, but seemed to be broken in 1.0.
Issues remain, however, since dill.dump_session now saves "DummyMod" stub and not the user's interactive session. Needs more investigation into reason behind DummyMod, and if it's really a necessary evil.