fix %magic output#3468
Conversation
call lsmagic without underscore closes ipython#3467
There was a problem hiding this comment.
We do have tt.AssertPrints, but it's a bit awkward for checking multiple things in the same block of output at present.
|
Other than that, looks fine to me. |
There was a problem hiding this comment.
Hey @minrk, let's not use yield(foo, args) in tests ever. Nose does horrible things in these scenarios. Instead, let's do regular foo(args) so the stack is comprehensible.
Specifically, in this case you should do nt.assert_in('%magic', stdout), and similar for the ones below.
There was a problem hiding this comment.
Sure, I was just copying the style of adjacent tests.
There was a problem hiding this comment.
yields (and the parametric tests they produced) are removed, and I went ahead and applied the same changes to the rest of test_magic.
at request of @fperez
use `assert_in` and `assert_equal` in place of a few `assert_true/false`
|
👍 |
fix `%magic` output
4 participants
call lsmagic without underscore
closes #3467