Skip to content

Improve the design of the tab completion UI#3238

Merged
ellisonbg merged 3 commits into
ipython:masterfrom
ellisonbg:tabstyle
May 1, 2013
Merged

Improve the design of the tab completion UI#3238
ellisonbg merged 3 commits into
ipython:masterfrom
ellisonbg:tabstyle

Conversation

@ellisonbg

Copy link
Copy Markdown
Member

This PR improves on the style of the tab completion UI by doing the following:

  • Rounded corners
  • White background
  • Font matches that of the CM editor
  • Horizontal alignment with the matched text.

Here is a sample.

Screen Shot 2013-04-29 at 2 02 48 PM

@fperez

fperez commented Apr 30, 2013

Copy link
Copy Markdown
Member

Quick reminder that the coloring in the previous version had semantic value we don't want to lose: it indicated whether a completion came from the local text scope or from the object's namespace.

One problem with the previous one, though, is that it would repeat the same completion if it was in both. In that case, it should remove the duplicates, leaving say only the namespace one. Because otherwise it refuses to 'finish' a completion that appears both locally and in the namespace even when it's the only one left, since both copies are kept making the logic mistakenly think it's non-unique.

@Carreau

Carreau commented Apr 30, 2013

Copy link
Copy Markdown
Member

Agreed with Fernando,
I'll be back from Japan in 24 hour and a little more. I see There is a
lot to catch up with. Give me time to get better from jet lag and I'll soon
be back in. I'll appreciate if you can point me to important point I'll
miss when skipping through 2 weeks of mails.

Le mardi 30 avril 2013, Fernando Perez a écrit :

Quick reminder that the coloring in the previous version had semantic
value we don't want to lose: it indicated whether a completion came from
the local text scope or from the object's namespace.

One problem with the previous one, though, is that it would repeat the
same completion if it was in both. In that case, it should remove the
duplicates, leaving say only the namespace one. Because otherwise it
refuses to 'finish' a completion that appears both locally and in the
namespace even when it's the only one left, since both copies are kept
making the logic mistakenly think it's non-unique.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3238#issuecomment-17205888
.

@ellisonbg

Copy link
Copy Markdown
Member Author

OK I have styled things in a way that takes into account the different completion types. Styling select options is a horrible mess - most things simply don't work. I think what I have now is a nice balance between being clean, but a good visual difference.

ellisonbg added a commit that referenced this pull request May 1, 2013
Improve the design of the tab completion UI
@ellisonbg ellisonbg merged commit 69bf6a4 into ipython:master May 1, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Improve the design of the tab completion UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants