add missing location when disambiguating controller IP #2269
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevented ip=* from resolving correctly engine-side This bug was introduced in the connection cleanup after 0.13, so does not need backporting.
Merged
Member
|
Straightforward enough, and since we've had confirmation in the discussion on-list that it does help, we can go ahead. Merging now, thanks! |
fperez
added a commit
that referenced
this pull request
Aug 9, 2012
add missing location when disambiguating controller IP. Fixes a recently introduced bug that prevented ip=* from resolving correctly engine-side (would always give loopback).
minrk
added a commit
that referenced
this pull request
Aug 9, 2012
* use pipes.quote on SSH commands * default SSHEngineSetLauncher to `ipengine` instead of import-based command. This is actually the intended behavior, and only brings EngineSet inline with SSHEngine and SSHController, which both use the simplified command. * Should be backported to 0.13.1 * Must be not be merged before #2269
minrk
added a commit
that referenced
this pull request
Sep 1, 2012
* use pipes.quote on SSH commands * default SSHEngineSetLauncher to `ipengine` instead of import-based command. This is actually the intended behavior, and only brings EngineSet inline with SSHEngine and SSHController, which both use the simplified command. * Should be backported to 0.13.1 * Must be not be merged before #2269
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
add missing location when disambiguating controller IP. Fixes a recently introduced bug that prevented ip=* from resolving correctly engine-side (would always give loopback).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevented ip=* from resolving correctly engine-side (would always give loopback)
This bug was introduced in the connection cleanup after 0.13, so does not need backporting.