Skip to content

ipcluster broken with any batch launcher (PBS/LSF/SGE) #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minrk merged 1 commit into from
Jul 15, 2012
Merged

ipcluster broken with any batch launcher (PBS/LSF/SGE) #2126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions IPython/parallel/apps/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import copy
import logging
import os
import pipes
import stat
import sys
import time
Expand Down Expand Up @@ -1141,7 +1142,7 @@ class PBSControllerLauncher(PBSLauncher, BatchClusterAppMixin):
#PBS -V
#PBS -N ipcontroller
%s --log-to-file --profile-dir="{profile_dir}" --cluster-id="{cluster_id}"
"""%(' '.join(ipcontroller_cmd_argv)))
"""%(' '.join(map(pipes.quote, ipcontroller_cmd_argv))))


def start(self):
Expand All @@ -1157,7 +1158,7 @@ class PBSEngineSetLauncher(PBSLauncher, BatchClusterAppMixin):
#PBS -V
#PBS -N ipengine
%s --profile-dir="{profile_dir}" --cluster-id="{cluster_id}"
"""%(' '.join(ipengine_cmd_argv)))
"""%(' '.join(map(pipes.quote,ipengine_cmd_argv))))

def start(self, n):
"""Start n engines by profile or profile_dir."""
Expand All @@ -1181,7 +1182,7 @@ class SGEControllerLauncher(SGELauncher, BatchClusterAppMixin):
#$ -S /bin/sh
#$ -N ipcontroller
%s --log-to-file --profile-dir="{profile_dir}" --cluster-id="{cluster_id}"
"""%(' '.join(ipcontroller_cmd_argv)))
"""%(' '.join(map(pipes.quote, ipcontroller_cmd_argv))))

def start(self):
"""Start the controller by profile or profile_dir."""
Expand All @@ -1195,7 +1196,7 @@ class SGEEngineSetLauncher(SGELauncher, BatchClusterAppMixin):
#$ -S /bin/sh
#$ -N ipengine
%s --profile-dir="{profile_dir}" --cluster-id="{cluster_id}"
"""%(' '.join(ipengine_cmd_argv)))
"""%(' '.join(map(pipes.quote, ipengine_cmd_argv))))

def start(self, n):
"""Start n engines by profile or profile_dir."""
Expand Down Expand Up @@ -1249,7 +1250,7 @@ class LSFControllerLauncher(LSFLauncher, BatchClusterAppMixin):
#BSUB -oo ipcontroller.o.%%J
#BSUB -eo ipcontroller.e.%%J
%s --log-to-file --profile-dir="{profile_dir}" --cluster-id="{cluster_id}"
"""%(' '.join(ipcontroller_cmd_argv)))
"""%(' '.join(map(pipes.quote,ipcontroller_cmd_argv))))

def start(self):
"""Start the controller by profile or profile_dir."""
Expand All @@ -1264,7 +1265,7 @@ class LSFEngineSetLauncher(LSFLauncher, BatchClusterAppMixin):
#BSUB -oo ipengine.o.%%J
#BSUB -eo ipengine.e.%%J
%s --profile-dir="{profile_dir}" --cluster-id="{cluster_id}"
"""%(' '.join(ipengine_cmd_argv)))
"""%(' '.join(map(pipes.quote, ipengine_cmd_argv))))

def start(self, n):
"""Start n engines by profile or profile_dir."""
Expand Down