[in progress] python 2 and 3 compatibility without 2to3, second try#2100
Conversation
There was a problem hiding this comment.
Since we're not disabling the print fixer, I think we should leave modules in external as they are for now.
|
Apart from the change to an |
|
I suggest we also apply/disable the raise fix, but this can be done later.
|
|
Yes, let's keep that for a separate pull request, so the diff doesn't get too big. Note that the |
|
Should #2095 be closed, then? |
|
Never mind, I just saw it had just slipped through the cracks, and closed #2095. Let's continue here. For the record, I agree with the print_function policy of updating to the py3 style only when |
|
Merge a commit sent by @bfroehle to apply the |
|
@Carreau: Maybe you should just squash the last two commits to preserve the history in deathrow/quarantine. |
|
At a glance, this all looks OK. Don't forget to send the exception fix in |
|
Test results for commit 62e140b merged into master
Not available for testing: python2.6 |
|
Forwarded |
|
Thanks. If there are no objections, merge away. I agree that we can squash the last 2 commits. |
|
Sounds like a good idea, but let's do another pull request for it. |
edited to avoid touching deathrow and quarantine by Bussonnier Matthias <bussonniermatthias@gmail.com>
|
Squashed and force pushed, |
python 2 and 3 compatibility without 2to3 apply some fixes : - apply (deactivated in setup.py now) - repr (deactivated in setup.py now) - print (only in modules with print >>) - raise (partially) don't touch deathrow and quarantine.
python 2 and 3 compatibility without 2to3 apply some fixes : - apply (deactivated in setup.py now) - repr (deactivated in setup.py now) - print (only in modules with print >>) - raise (partially) don't touch deathrow and quarantine.
After discussion in #2095, apply a smaller set of 2to3 fix.