Repository navigation
Fix dictionary pretty printing during mutation - #15468
Open
arshiya-md wants to merge 2 commits into
Open
arshiya-md wants to merge 2 commits into
arshiya-md wants to merge 2 commits into
Conversation
arshiya-md
force-pushed
the
fix/14541-vars-posix-runtime-error
branch
from
November 2, 2026 16:17
0481bbc to
d8d9faa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14541.
The dictionary pretty printer previously iterated over a live dict_keys view. If formatting a dictionary value mutated the dictionary, iteration could raise RuntimeError: dictionary changed size during iteration.
This change snapshots dictionary keys before formatting values. When max_seq_length is configured, islice limits the snapshot to max_seq_length + 1 keys, avoiding unnecessary allocation proportional to the full dictionary size.
Tests
Added a regression test for dictionary mutation during value formatting.
Added a test verifying bounded key consumption with max_seq_length.