Repository navigation
Install ipykernel test requirements from its dependency group in downstream CI - #15418
Merged
krassowski merged 2 commits intoOct 20, 2026
Merged
krassowski merged 2 commits into
krassowski merged 2 commits into
Conversation
ipykernel moved its test requirements from the "test" extra to a "test" dependency group (ipython/ipykernel#1563). "pip install -e .[test]" now only warns that the extra does not exist, so pytest-timeout is not installed and the downstream ipykernel tests fail to collect with "Unknown config option: timeout" / "'timeout' not found in markers".
This was referenced Oct 5, 2026
Contributor
Author
|
The red check here is the mypy job ( |
krassowski
approved these changes
Oct 20, 2026
krassowski
left a comment
krassowski
left a comment
Member
There was a problem hiding this comment.
Thanks, but let's drop the comment, if we included comment for every historical change, we would need to buy a separate datacenter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Run Downstream tests workflow has been failing on
main, including the weekly scheduled run (e.g. https://github.com/ipython/ipython/actions/runs/37253135992). The ipykernel step stops during collection:ipykernel moved its test requirements from the
testextra to atestdependency group in ipython/ipykernel#1563 (2026-09-21). Since then,pip install -e .[test]only printsWARNING: ipykernel 7.4.0 does not provide the extra 'test', and pytest-timeout and the other test requirements are never installed.This PR changes the step to
pip install -e . --group test, which needs pip ≥ 25.1. The workflow already upgrades pip to the latest version.I checked the install locally against a fresh ipykernel clone (pip 26.2.1, Python 3.13):
.[test]gives the warning above, andpytest-timeoutis not installed.. --group testinstalls pytest-timeout 2.4.0, pytest 9.1.1, etc., andpytest --cocollects the suite without the config error.I couldn't run the full ipykernel suite on Linux, so this PR's own run of the workflow will be the first check of whether anything else in that job is broken.
The pyflyby step further down still uses
.[test]. That's correct: pyflyby still definestestunder[project.optional-dependencies].