Avoid psutil requirement on Cygwin#15247
Open
UTSAV-2024 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15245.
This mirrors the approach taken in PR #15190 for emscripten.
psutildoes not support thecygwinplatform and causespip install ipythonto fail. The only current use ofpsutilin IPython is inIPython/core/kitty.pyfor terminal graphics detection.That feature is already gated to Darwin and Linux terminals, so it is never exercised on Cygwin. Excluding
psutilfrom dependencies on Cygwin restores installation support without affecting runtime behavior.Testing
psutilis only imported fromIPython/core/kitty.py.