fix: only surface nested repr_mimebundle NotImplementedError#15168
Open
Maa-ly wants to merge 2 commits into
Open
fix: only surface nested repr_mimebundle NotImplementedError#15168Maa-ly wants to merge 2 commits into
Maa-ly wants to merge 2 commits into
Conversation
Carreau
approved these changes
Apr 10, 2026
Carreau
left a comment
Carreau
left a comment
Member
There was a problem hiding this comment.
+1 in principle (reviewing from my phone) i need to check and think about reaching for the global ipython instance.
Maa-ly
changed the title
Author
|
The previous version made every Local validation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15154
Summary
NotImplementedErroropt-outs from repr methods so interactive fallbacks keep working_repr_mimebundle_NotImplementedErrors from helper code instead of silently discarding themValidation
source .venv/bin/activate && pytest tests/test_formatters.py -q