chore: add 5 return type hints in completer.py#15159
Draft
travellingsoldier85 wants to merge 1 commit into
Draft
chore: add 5 return type hints in completer.py#15159travellingsoldier85 wants to merge 1 commit into
travellingsoldier85 wants to merge 1 commit into
Conversation
Member
|
In general don't stop to just |
Carreau
force-pushed
the
auto-improve/type_hint/209aa0-202603170902
branch
from
8ee873f to
6155c34
Compare
Member
|
https://typing.python.org/en/latest/reference/generics.html for introduction on generics. |
themavik
reviewed
Mar 23, 2026
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
nit: bare list/tuple return annotations help little; if you are editing these, prefer list[str] or a concrete tuple type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added concrete return type annotations to functions in
IPython/core/completer.pybased on static analysis of return statements.Changes
-> listto function-> listto function-> tupleto function-> boolto function-> listto functionType of Change
Motivation
These type annotations are inferred from actual return values in the function bodies (e.g.
return True→-> bool,return []→-> list). They improve:No functional changes — only type annotations added.