Populate notebook metadata when exporting with %notebook magic#14955
Merged
krassowski merged 2 commits intoipython:mainfrom Aug 8, 2025
Merged
Populate notebook metadata when exporting with %notebook magic#14955krassowski merged 2 commits intoipython:mainfrom
%notebook magic#14955krassowski merged 2 commits intoipython:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds metadata population to the %notebook magic command when exporting notebooks to fix issue #14954. The change ensures that exported notebooks include proper kernel and language information.
- Populates notebook metadata with kernelspec and language_info when using
%notebookmagic - Adds test validation to verify the exported metadata contains correct Python version and kernel information
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| IPython/core/magics/basic.py | Adds metadata dictionary with kernelspec and language_info to v4.new_notebook() call |
| tests/test_magic.py | Adds test assertions to validate the exported notebook metadata contains expected values |
Member
Author
|
CC @Darshan808 for review :) |
Collaborator
|
This looks good. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14954