Skip to content

support using '%run -m' for modules importable via an import hook - #12171

Merged
Carreau merged 1 commit into
ipython:masterfrom
ngoldbaum:run-module-import-hook
Mar 14, 2020
Merged

Carreau merged 1 commit into
ipython:masterfrom
ngoldbaum:run-module-import-hook

Conversation

@ngoldbaum

@ngoldbaum ngoldbaum commented Mar 5, 2020 •

Copy link
Copy Markdown
Contributor

Fixes #11736

Current %run -m can't be used with modules that are loadable via an import hook. This makes that possible. I've also added a test to confirm that this works as expected, using the test script provided by @mlucool in the issue.

@Carreau

Carreau commented Mar 9, 2020

Copy link
Copy Markdown
Member

Test are due to a regression in mpl, fixed there

@Carreau
Carreau force-pushed the run-module-import-hook branch from c4acb3d to 6e07950 Compare March 11, 2020 14:56
@Carreau Carreau added this to the 8.0 milestone Mar 14, 2020
@Carreau
Carreau merged commit 0395aa5 into ipython:master Mar 14, 2020
@Carreau

Carreau commented Mar 14, 2020

Copy link
Copy Markdown
Member

Thanks ! I rebased and force push to fix CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

%run does not work with import hooks

2 participants