Repository navigation
FIX: bare functions in callback registry on bogus unregister - #10867
Merged
takluyver merged 3 commits intoOct 25, 2017
Merged
Conversation
7de483b added checking for the case where the callback was wrapped by backcall, however if there are un-wrapped functions registered and a non-registered function is attempted to be unregistered then this fails by raise an uncaught AttributeError.
Member
|
Thanks! Tests in |
Contributor
Author
|
I can drop the last commit if you want, just being a difficult busy body / making my editor less angry.... |
tacaswell
force-pushed
the
fix_bare_function_unregister
branch
from
October 23, 2017 23:56
636adbf to
b7d1abe
Compare
Member
|
The wrapping is fine, but can you fix the test? ;-) |
tacaswell
force-pushed
the
fix_bare_function_unregister
branch
from
October 24, 2017 13:27
b7d1abe to
2494045
Compare
Contributor
Author
|
cargo-culted how to test raising.... |
Member
|
Needs a bit more cargo ;-) import nose.tools as nt |
tacaswell
force-pushed
the
fix_bare_function_unregister
branch
from
October 25, 2017 20:10
2494045 to
3abd0c2
Compare
Contributor
Author
|
3rd times the charm? |
Member
|
Seems it is! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7de483b added checking for the case
where the callback was wrapped by backcall, however if there are
un-wrapped functions registered and a non-registered function is
attempted to be unregistered then this fails by raise an uncaught
AttributeError.
Where should a test for this go?