Skip to content

Commit fe3786a

Browse files
committed
cleanup per review by @fperez
* '127' in url -> url.startswith('127.') * engines_started_okay -> engines_started_ok
1 parent 2fad3ac commit fe3786a

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎IPython/parallel/apps/ipclusterapp.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ def build_launcher(self, clsname, kind=None):
321321
)
322322
return launcher
323323

324-
def engines_started_okay(self):
324+
def engines_started_ok(self):
325325
self.log.info("Engines appear to have started successfully")
326326
self.early_shutdown = 0
327327

@@ -330,7 +330,7 @@ def start_engines(self):
330330
self.engine_launcher.start(self.n)
331331
self.engine_launcher.on_stop(self.engines_stopped_early)
332332
if self.early_shutdown:
333-
ioloop.DelayedCallback(self.engines_started_okay, self.early_shutdown*1000, self.loop).start()
333+
ioloop.DelayedCallback(self.engines_started_ok, self.early_shutdown*1000, self.loop).start()
334334

335335
def engines_stopped_early(self, r):
336336
if self.early_shutdown and not self._stopping:

‎IPython/parallel/engine/engine.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ def complete_registration(self, msg, connect, maybe_tunnel):
214214

215215
def abort(self):
216216
self.log.fatal("Registration timed out after %.1f seconds"%self.timeout)
217-
if '127' in self.url:
217+
if self.url.startswith('127.'):
218218
self.log.fatal("""
219219
If the controller and engines are not on the same machine,
220220
you will have to instruct the controller to listen on an external IP (in ipcontroller_config.py):

0 commit comments

Comments
 (0)