Ensure test_start_app takes 1s to stop kernel#1364
Merged
davidbrochart merged 1 commit intoipython:mainfrom Feb 26, 2025
Merged
Ensure test_start_app takes 1s to stop kernel#1364davidbrochart merged 1 commit intoipython:mainfrom
davidbrochart merged 1 commit intoipython:mainfrom
Conversation
Collaborator
Author
|
The test fails, meaning that it shouldn't pass on |
Collaborator
Author
|
This just makes the test useful. Let's merge it and fix the test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.