Conversation
krassowski
reviewed
Dec 16, 2024
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
This works, thank you!
Do I guess right that the issue was introduced in #1079 by this change:
if self.subapp is not None:
+ self.subapp.start()
- return self.subapp.start()I wonder if return status here makes a difference for some command line applications.
Collaborator
Author
Actually I think we should rather revert that change, thanks for finding it. |
davidbrochart
force-pushed
the
fix-install
branch
2 times, most recently
from
bc3fe27 to
a2f2ae8
Compare
davidbrochart
force-pushed
the
fix-install
branch
from
117a295 to
007d12f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1309