make debugger class configurable#1307
Conversation
jasongrout
left a comment
jasongrout
left a comment
There was a problem hiding this comment.
Awesome, thanks! In full disclosure, we'd like this at Databricks (where Stephen and I both work) because we customize the debugger class.
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
It seems fine, but not 100% sure as I get an error when trying to install kernel: #1309
|
Can this get rebased to trigger CI (I try to do it, but there is no allow push from maintainers). |
smacke
force-pushed
the
smacke/configurable-debugger
branch
from
6bd5782 to
175f1dc
Compare
for more information, see https://pre-commit.ci
|
Hey @Carreau just rebased + pushed |
|
There is one minor lint to fix (unused mypy ignore), and I restarted the test on 3.9. I would actually be in favor of dropping 3.9 support (per https://scientific-python.org/specs/spec-0000/), and FYI IPython CLI already dropped 3.10. |
|
@Carreau did you want me to fix those lint failures? They don't seem related with this change but happy to do it anyway |
|
No, it was just a "the failures are know and fixed on master". I haven't been involved in ipykernel in a while and was reluctant to merge, but I think that's ok. |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
5 participants
In this PR, add fields
compiler_classanddebugger_classdefaulting to the normal types. Kernel subclasses can override these to provide additional customizations.