Execute code in blocking mode by default#1233
Open
davidbrochart wants to merge 1 commit intoipython:anyiofrom
Open
Execute code in blocking mode by default#1233davidbrochart wants to merge 1 commit intoipython:anyiofrom
davidbrochart wants to merge 1 commit intoipython:anyiofrom
Conversation
davidbrochart
force-pushed
the
fix-interrupt
branch
from
5102411 to
fdcef67
Compare
davidbrochart
changed the title
ianthomas23
approved these changes
May 14, 2024
Collaborator
ianthomas23
left a comment
ianthomas23
left a comment
There was a problem hiding this comment.
I've manually confirmed that this does indeed fix some of the downstream jupyter_client test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes jupyter-client's test_signal_kernel_subprocesses.
shell_is_blocking=Trueis now set by default when executing code. A kernel running in async mode should override withshell_is_blocking=Falseandshell_is_awaiting=True.