Correctly handle with_cell_id in async do_execute#1227
Merged
blink1073 merged 1 commit intoipython:mainfrom Apr 3, 2024
Merged
Correctly handle with_cell_id in async do_execute#1227blink1073 merged 1 commit intoipython:mainfrom
blink1073 merged 1 commit intoipython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the minimum dependency tests following the switch to AnyIO (#1079).
In
IPythonKernel.do_executewe determine ifcell_idis supported usingor similar. This returns a dict, either
{"cell_id", True}or{"cell_id", False}.But when testing this we use
which gives the correct answer if
cell_idis supported but the wrong one otherwise. It needs to beinstead, which is all this PR does.
It happened to work for IPython >= 8.3.0 because of ipython/ipython#13600 so that
cell_idis always accepted, but failed for IPython <= 8.2.0.