Allow datetime or str in test_sequential_control_messages#1219
Merged
blink1073 merged 3 commits intoipython:mainfrom Mar 4, 2024
Merged
Allow datetime or str in test_sequential_control_messages#1219blink1073 merged 3 commits intoipython:mainfrom
blink1073 merged 3 commits intoipython:mainfrom
Conversation
Collaborator
Author
|
Failures here are the same as in the last scheduled CI run https://github.com/ipython/ipykernel/actions/runs/8134006247 |
Contributor
|
This failure on Windows looks relevant: |
Collaborator
Author
|
Windows tests are passing now. |
ianthomas23
added a commit
to ianthomas23/ipykernel
that referenced
this pull request
Apr 11, 2025
Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1218.
test_sequential_control_messagesadded in #1210 compares twodatetimes returned in execute_reply messages. Some downstream libraries (ipyparallel) keep them as strings for performance reasons, so here allow this test to accept datetime or strings, otherwise this test is testing the return types rather than the intended sequence of control messages.Once this passes CI here and is merged, we will need to check that
IPythons CI also passes before we can be sure that it is fully fixed.