Send back "comm_close" to unidentified/closed communications#18
Open
dby-tmwctw wants to merge 7 commits intoipython:mainfrom
Open
Send back "comm_close" to unidentified/closed communications#18dby-tmwctw wants to merge 7 commits intoipython:mainfrom
dby-tmwctw wants to merge 7 commits intoipython:mainfrom
Conversation
dby-tmwctw
changed the title
dby-tmwctw
commented
Oct 5, 2023
| primary=False, | ||
| target_name=None, | ||
| ) | ||
| closed_comm.close() |
Author
There was a problem hiding this comment.
We should have some metadata sent back associated with comm_close so we are able to identify the source.
Contributor
|
Hi @dby-tmwctw, I'm just catching up on this repo, is PR ready to be merged? Does jupyter-widgets/ipywidgets#3833 depend on this PR, or the other way around, or are they independent? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Motivation
Currently, sending communications to closed comm is a no-op. This caused sender to be unable to determine whether the backend hangs or the comm is closed, directly causing the bug described here: jupyter-widgets/ipywidgets#3833. We noticed that similar case in
comm_openrequests would cause it to send backcomm_closed: https://jupyter-client.readthedocs.io/en/latest/messaging.html#opening-a-comm, hence we propose this PR to do the same forcomm_msg.