Fix passing None to urlparse.

sigmavirus24 · sigmavirus24 · commit fe9bcf6a903e · 2012-09-17T18:07:52.000-04:00
Also fix test in test_repos.
diff --git a/github3/gists.py b/github3/gists.py
@@ -67,8 +67,7 @@ def __init__(self, data, session=None):
         self.description = data.get('description', '')
 
         # e.g. https://api.github.com/gists/1
-        self._api = data.get('url')
-        #self._api = self._build_url('gists', str(self._id))
+        self._api = data.get('url', '')
 
         #: URL of this gist at Github, e.g., https://gist.github.com/1
         self.html_url = data.get('html_url')
diff --git a/github3/git.py b/github3/git.py
@@ -17,7 +17,7 @@ class Blob(GitHubObject):
     """The :class:`Blob <Blob>` object."""
     def __init__(self, blob):
         super(Blob, self).__init__(blob)
-        self._api = blob.get('url')
+        self._api = blob.get('url', '')
 
         #: Raw content of the blob.
         self.content = blob.get('content').encode()
@@ -48,7 +48,7 @@ def __init__(self, data, session=None):
         super(GitData, self).__init__(data, session)
         #: SHA of the object
         self.sha = data.get('sha')
-        self._api = data.get('url')
+        self._api = data.get('url', '')
 
 
 class Commit(BaseCommit):
@@ -89,7 +89,7 @@ class Reference(GitHubCore):
     """
     def __init__(self, ref, session=None):
         super(Reference, self).__init__(ref, session)
-        self._api = ref.get('url')
+        self._api = ref.get('url', '')
         #: The reference path, e.g., refs/heads/sc/featureA
         self.ref = ref.get('ref')
         #: :class:`GitObject <GitObject>` the reference points to
diff --git a/github3/issues.py b/github3/issues.py
@@ -18,7 +18,7 @@ class Label(GitHubCore):
     exists in a repository."""
     def __init__(self, label, session=None):
         super(Label, self).__init__(label, session)
-        self._api = label.get('url')
+        self._api = label.get('url', '')
         #: Color of the label, e.g., 626262
         self.color = label.get('color')
         #: Name of the label, e.g., 'bug'
@@ -64,7 +64,7 @@ class Milestone(GitHubCore):
     """
     def __init__(self, mile, session=None):
         super(Milestone, self).__init__(mile, session)
-        self._api = mile.get('url')
+        self._api = mile.get('url', '')
         #: Identifying number associated with milestone.
         self.number = mile.get('number')
         #: State of the milestone, e.g., open or closed.
@@ -141,7 +141,7 @@ class Issue(GitHubCore):
     """
     def __init__(self, issue, session=None):
         super(Issue, self).__init__(issue, session)
-        self._api = issue.get('url')
+        self._api = issue.get('url', '')
         #: :class:`User <github3.users.User>` representing the user the issue
         #  was assigned to.
         self.assignee = None
@@ -377,7 +377,7 @@ def __init__(self, event, issue=None):
         self.event = event.get('event')
         #: SHA of the commit.
         self.commit_id = event.get('commit_id')
-        self._api = event.get('url')
+        self._api = event.get('url', '')
 
         #: :class:`Issue <Issue>` where this comment was made.
         self.issue = issue
diff --git a/github3/models.py b/github3/models.py
@@ -157,7 +157,7 @@ def __init__(self, comment, session):
         #: datetime object representing when the comment was updated.
         self.updated_at = self._strptime(comment.get('updated_at'))
 
-        self._api = comment.get('url')
+        self._api = comment.get('url', '')
         self.links = comment.get('_links')
         #: The url of this comment at GitHub
         self.html_url = ''
@@ -204,7 +204,7 @@ class BaseCommit(GitHubCore):
     """
     def __init__(self, commit, session):
         super(BaseCommit, self).__init__(commit, session)
-        self._api = commit.get('url')
+        self._api = commit.get('url', '')
         #: SHA of this commit.
         self.sha = commit.get('sha')
         #: Commit message
diff --git a/github3/orgs.py b/github3/orgs.py
@@ -17,7 +17,7 @@
 class Team(GitHubCore):
     def __init__(self, team, session=None):
         super(Team, self).__init__(team, session)
-        self._api = team.get('url')
+        self._api = team.get('url', '')
         #: This team's name.
         self.name = team.get('name')
         #: Unique ID of the team.
diff --git a/github3/pulls.py b/github3/pulls.py
@@ -75,7 +75,7 @@ class PullRequest(GitHubCore):
     """The :class:`PullRequest <PullRequest>` object."""
     def __init__(self, pull, session=None):
         super(PullRequest, self).__init__(pull, session)
-        self._api = pull.get('url')
+        self._api = pull.get('url', '')
         #: Base of the merge
         self.base = PullDestination(pull.get('base'), 'Base')
         #: Body of the pull request message
diff --git a/github3/repos.py b/github3/repos.py
@@ -87,7 +87,7 @@ def __init__(self, repo, session=None):
         #: ``datetime`` object representing the last time the repository was
         #  updated.
         self.updated_at = self._strptime(repo.get('updated_at'))
-        self._api = repo.get('url')
+        self._api = repo.get('url', '')
 
         # The number of watchers
         #: Number of users watching the repository.
@@ -1309,7 +1309,7 @@ class Contents(GitHubObject):
     def __init__(self, content):
         super(Contents, self).__init__(content)
         # links
-        self._api = content['_links'].get('self')
+        self._api = content['_links'].get('self', '')
         #: Dictionary of links
         self.links = content.get('_links')
 
@@ -1361,7 +1361,7 @@ class Download(GitHubCore):
 
     def __init__(self, download, session=None):
         super(Download, self).__init__(download, session)
-        self._api = download.get('url')
+        self._api = download.get('url', '')
         #: URL of the download at GitHub.
         self.html_url = download.get('html_url')
         #: Unique id of the download on GitHub.
@@ -1410,7 +1410,7 @@ class Hook(GitHubCore):
 
     def __init__(self, hook, session=None):
         super(Hook, self).__init__(hook, session)
-        self._api = hook.get('url')
+        self._api = hook.get('url', '')
         #: datetime object representing when this hook was last updated.
         self.updated_at = None
         if hook.get('updated_at'):
@@ -1624,7 +1624,7 @@ class Comparison(GitHubObject):
 
     def __init__(self, compare):
         super(Comparison, self).__init__(compare)
-        self._api = compare.get('api')
+        self._api = compare.get('api', '')
         #: URL to view the comparison at GitHub
         self.html_url = compare.get('html_url')
         #: Permanent link to this comparison.
diff --git a/github3/users.py b/github3/users.py
@@ -17,7 +17,7 @@ class Key(GitHubCore):
     """The :class:`Key <Key>` object."""
     def __init__(self, key, session=None):
         super(Key, self).__init__(key, session)
-        self._api = key.get('url')
+        self._api = key.get('url', '')
         #: The text of the actual key
         self.key = key.get('key')
         #: The unique id of the key at GitHub
diff --git a/tests/test_repos.py b/tests/test_repos.py
@@ -123,7 +123,7 @@ def test_contents(self):
         expect(contents).isinstance(Contents)
 
     def test_download(self):
-        download = self.alt_repo.download(310737)
+        download = self.repo.download(316176)
         expect(download).isinstance(Download)
 
     def test_git_commit(self):
@@ -384,6 +384,8 @@ def test_create_key(self):
             pass
 
     def test_edit(self):
+        if not self.auth:
+            return
         old = {'name': self.alt_repo.name,
                 'description': self.alt_repo.description,
                 'homepage': self.alt_repo.homepage,
