fix(textarea): add reflect option to disabled and readonly props#30910
Open
KillerCodeMonkey wants to merge 3 commits intoionic-team:mainfrom
Open
fix(textarea): add reflect option to disabled and readonly props#30910KillerCodeMonkey wants to merge 3 commits intoionic-team:mainfrom
KillerCodeMonkey wants to merge 3 commits intoionic-team:mainfrom
Conversation
To be consistent with ion-input and could be useful for styling purposes, since there is no "readonly" css class
|
@KillerCodeMonkey is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
gnbm
requested review from
brandyscarney
and removed request for
OS-jacobbell
gnbm
added
type: feature request
brandyscarney
requested review from
thetaPC
and removed request for
brandyscarney
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflect
readonlyanddisabledproperties ation-textareahost element.Issue number: resolves #30911
What is the current behavior?
When setting readonly or disabled those settings are only reflected deep inside the ion-textarea component at the native textarea element.
Since there is no predefined readonly class it is hard to select readonly/disabled ion-textareas.
What is the new behavior?
Readonly and disabled props are reflected at ion-textarea host element.
Like they are for ion-inputs.
So it is consistent and will be helpful for easy element selection of disabled/readonly textareas (css, querySelector).
Does this introduce a breaking change?
Other information